You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/10/09 16:52:15 UTC
[GitHub] [kylin] AndrewLane opened a new pull request #1441: Correct grammar of message when there are no cubes
AndrewLane opened a new pull request #1441:
URL: https://github.com/apache/kylin/pull/1441
## Proposed changes
Grammar fix on message when there are no cubes.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ x ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1441: Correct grammar of message when there are no cubes
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1441:
URL: https://github.com/apache/kylin/pull/1441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls commented on pull request #1441: Correct grammar of message when there are no cubes
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1441:
URL: https://github.com/apache/kylin/pull/1441#issuecomment-706338136
## Pull Request Test Coverage Report for [Build 6437](https://coveralls.io/builds/34065974)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **9** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.009%**) to **28.042%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/MetricsSystem.java](https://coveralls.io/builds/34065974/source?filename=core-metrics%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetrics%2Flib%2Fimpl%2FMetricsSystem.java#L46) | 9 | 60.0% |
<!-- | **Total:** | **9** | | -->
| Totals | [](https://coveralls.io/builds/34065974) |
| :-- | --: |
| Change from base [Build 6416](https://coveralls.io/builds/33804340): | -0.009% |
| Covered Lines: | 26248 |
| Relevant Lines: | 93602 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1441: Correct grammar of message when there are no cubes
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1441:
URL: https://github.com/apache/kylin/pull/1441#issuecomment-706482161
Thank you @AndrewLane
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org