You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "mitdesai (via GitHub)" <gi...@apache.org> on 2023/05/19 19:17:32 UTC
[GitHub] [yunikorn-k8shim] mitdesai commented on pull request #594: [YUNIKORN-1273] Add configurable option to have unique application ids in a namespace
mitdesai commented on PR #594:
URL: https://github.com/apache/yunikorn-k8shim/pull/594#issuecomment-1555124234
> ## [Codecov](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/594?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> > Merging [#594](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/594?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ([0f9aed1](https://github.com/apache/yunikorn-k8shim/commit/0f9aed121d58f362d578520657251b4c73bc2b8b)) into [master](https://app.codecov.io/gh/apache/yunikorn-k8shim/commit/2d91d01b80602000daa74dd8221e326e75521a46?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ([2d91d01](https://github.com/apache/yunikorn-k8shim/commit/2d91d01b80602000daa74dd8221e326e75521a46)) will **decrease** coverage by `0.01%`.
> > The diff coverage is `80.95%`.
>
> > ❗ Current head [0f9aed1](https://github.com/apache/yunikorn-k8shim/commit/0f9aed121d58f362d578520657251b4c73bc2b8b) differs from pull request most recent head [df70048](https://github.com/apache/yunikorn-k8shim/commit/df7004844b94369f8f2a189771c28302bcb1393f). Consider uploading reports for the commit [df70048](https://github.com/apache/yunikorn-k8shim/commit/df7004844b94369f8f2a189771c28302bcb1393f) to get more accurate results
>
> ```diff
> @@ Coverage Diff @@
> ## master #594 +/- ##
> ==========================================
> - Coverage 69.95% 69.94% -0.01%
> ==========================================
> Files 47 47
> Lines 7938 7950 +12
> ==========================================
> + Hits 5553 5561 +8
> - Misses 2177 2181 +4
> Partials 208 208
> ```
>
> [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Coverage Δ
> [pkg/admission/conf/am_conf.go](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2FkbWlzc2lvbi9jb25mL2FtX2NvbmYuZ28=) `64.80% <20.00%> (-0.99%)` ⬇️
> [pkg/admission/admission_controller.go](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2FkbWlzc2lvbi9hZG1pc3Npb25fY29udHJvbGxlci5nbw==) `65.93% <100.00%> (-0.27%)` ⬇️
> [pkg/admission/util.go](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2FkbWlzc2lvbi91dGlsLmdv) `95.83% <100.00%> (+1.23%)` ⬆️
> 📣 We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
1. Added tests for ``am_conf.go``
2. ``admission_controller.go`` had a function moved to ``utils.go`` hence the difference in the covered lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org