[GitHub] [airflow] mik-laj commented on a change in pull request #5623: [AIRFLOW-5002] Diagnostics of getopt fixed for zsh on MacOS

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #5623: [AIRFLOW-5002] Diagnostics of getopt fixed for zsh on MacOS
URL: https://github.com/apache/airflow/pull/5623#discussion_r305889132
 
 

 ##########
 File path: CONTRIBUTING.md
 ##########
 @@ -281,11 +281,21 @@ clean the docker disk space periodically.
 If you are on MacOS:
 
 * Run `brew install gnu-getopt coreutils` (if you use brew, or use equivalent command for ports)
-* Then (with brew) link the gnu-getopt to become default as suggested by brew by typing.
+* Then (with brew) link the gnu-getopt to become default as suggested by brew by typing:
 ```bash
-echo 'export PATH=\"/usr/local/opt/gnu-getopt/bin:\$PATH\"' >> ~/.bash_profile"
-. ~/.bash_profile"
+echo 'export PATH="/usr/local/opt/gnu-getopt/bin:$PATH"' >> ~/.bash_profile
+. ~/.bash_profile
 ```
+
+if you use bash or
 
 Review comment:
   The sentence structure, which first shows the command and then the condition, is difficult to understand. Can you write a sentence so that the condition first and then the command?
   Example: 
   > If you are using bash,  then you should execute the command:
   > If you are using zsh, then you should execute the command:
   Sentences are correct, but in the presented construction they will be easier to understand.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services