[jira] [Commented] (TS-3675) Make HTTP/2 upgrade contexts handle bad settings properly

["Bryan Call (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588298#comment-14588298 ] 

Bryan Call commented on TS-3675:
--------------------------------

Invalid settings frame is being sent.  Do what the RFC says, most likely send GOAWAY.

> Make HTTP/2 upgrade contexts handle bad settings properly
> ---------------------------------------------------------
>
>                 Key: TS-3675
>                 URL: https://issues.apache.org/jira/browse/TS-3675
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP/2
>            Reporter: Leif Hedstrom
>             Fix For: sometime
>
>
> Right now, we have:
> {code}
>       if (!http2_parse_settings_parameter(make_iovec(out_buf + nbytes, HTTP2_SETTINGS_PARAMETER_LEN), param) ||
>            !http2_settings_parameter_is_valid(param)) {
>          // TODO ignore incoming invalid parameters and send suitable SETTINGS frame.
> {code}
> And then we continue trying to set the "invalid" parameter anyways.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)