You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/10 09:24:48 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #78: chore: version
tokers opened a new pull request #78:
URL: https://github.com/apache/apisix-ingress-controller/pull/78
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #78: chore: version
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #78:
URL: https://github.com/apache/apisix-ingress-controller/pull/78#discussion_r540618368
##########
File path: pkg/version/version.go
##########
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package version
+
+import (
+ "fmt"
+ "runtime"
+)
+
+var (
+ // The following fields are populated at build time using -ldflags -X.
+ _buildVersion = "unknown"
+ _buildGitRevision = "unknown"
+
+ _buildGoVersion = runtime.Version()
+)
+
+// Version produces a single-line version info with format:
+// <version>-<git revision>-<go version>
Review comment:
All right, i changed my mind, the build os will confuse users when the binary was compiled crossly.
I will add a verbose version info, which contains this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #78: chore: version
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #78:
URL: https://github.com/apache/apisix-ingress-controller/pull/78#issuecomment-742932326
@gxthrj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #78: chore: version
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #78:
URL: https://github.com/apache/apisix-ingress-controller/pull/78#discussion_r540015874
##########
File path: pkg/version/version.go
##########
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package version
+
+import (
+ "fmt"
+ "runtime"
+)
+
+var (
+ // The following fields are populated at build time using -ldflags -X.
+ _buildVersion = "unknown"
+ _buildGitRevision = "unknown"
+
+ _buildGoVersion = runtime.Version()
+)
+
+// Version produces a single-line version info with format:
+// <version>-<git revision>-<go version>
Review comment:
You mean the runnning OS or the building OS?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #78: chore: version
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #78:
URL: https://github.com/apache/apisix-ingress-controller/pull/78
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #78: chore: version
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #78:
URL: https://github.com/apache/apisix-ingress-controller/pull/78#discussion_r540014383
##########
File path: pkg/version/version.go
##########
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package version
+
+import (
+ "fmt"
+ "runtime"
+)
+
+var (
+ // The following fields are populated at build time using -ldflags -X.
+ _buildVersion = "unknown"
+ _buildGitRevision = "unknown"
+
+ _buildGoVersion = runtime.Version()
+)
+
+// Version produces a single-line version info with format:
+// <version>-<git revision>-<go version>
Review comment:
Suggest to add information about the operating system to facilitate troubleshooting due to different build platforms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #78: chore: version
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #78:
URL: https://github.com/apache/apisix-ingress-controller/pull/78#discussion_r540595793
##########
File path: pkg/version/version.go
##########
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package version
+
+import (
+ "fmt"
+ "runtime"
+)
+
+var (
+ // The following fields are populated at build time using -ldflags -X.
+ _buildVersion = "unknown"
+ _buildGitRevision = "unknown"
+
+ _buildGoVersion = runtime.Version()
+)
+
+// Version produces a single-line version info with format:
+// <version>-<git revision>-<go version>
Review comment:
OK, will add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on pull request #78: chore: version
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #78:
URL: https://github.com/apache/apisix-ingress-controller/pull/78#issuecomment-742962078
@gxthrj ping
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #78: chore: version
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #78:
URL: https://github.com/apache/apisix-ingress-controller/pull/78#discussion_r540218361
##########
File path: pkg/version/version.go
##########
@@ -0,0 +1,34 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package version
+
+import (
+ "fmt"
+ "runtime"
+)
+
+var (
+ // The following fields are populated at build time using -ldflags -X.
+ _buildVersion = "unknown"
+ _buildGitRevision = "unknown"
+
+ _buildGoVersion = runtime.Version()
+)
+
+// Version produces a single-line version info with format:
+// <version>-<git revision>-<go version>
Review comment:
building OS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org