You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/10/24 15:27:16 UTC

[PR] refactor: move cleanup logics to sr.done [pulsar-client-go]

tisonkun opened a new pull request, #1120:
URL: https://github.com/apache/pulsar-client-go/pull/1120

   This refers to https://github.com/apache/pulsar-client-go/pull/1071. This follows up to https://github.com/apache/pulsar-client-go/pull/1118.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: prepare sendrequest and move to internalSendAsync [pulsar-client-go]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #1120:
URL: https://github.com/apache/pulsar-client-go/pull/1120


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor: prepare sendrequest and move to internalSendAsync [pulsar-client-go]

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #1120:
URL: https://github.com/apache/pulsar-client-go/pull/1120#issuecomment-1778689777

   Merging...
   
   I'm rebasing #1121 onto this patch to fix two resource management issues with a unsplittable refactor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org