You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Rick Hillegas (JIRA)" <ji...@apache.org> on 2010/05/13 18:09:42 UTC
[jira] Created: (DERBY-4659) Allow routines to take arguments of
BOOLEAN type
Allow routines to take arguments of BOOLEAN type
------------------------------------------------
Key: DERBY-4659
URL: https://issues.apache.org/jira/browse/DERBY-4659
Project: Derby
Issue Type: Improvement
Components: SQL
Reporter: Rick Hillegas
We should allow routines to take BOOLEAN arguments as part of our expanding support for the BOOLEAN datatype.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4659) Allow routines to take arguments of
BOOLEAN type
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-4659:
---------------------------------
Attachment: derby-4659-02-aa-getFunctionColumns.diff
Attaching derby-4659-02-aa-getFunctionColumns.diff. This adds a regression test for getFunctionColumns() for functions with BOOLEAN args. Committed at subversion revision 956970.
Touches the following files:
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/TestDbMetaData.java
> Allow routines to take arguments of BOOLEAN type
> ------------------------------------------------
>
> Key: DERBY-4659
> URL: https://issues.apache.org/jira/browse/DERBY-4659
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4659-01-aa-functionArgs.diff, derby-4659-02-aa-getFunctionColumns.diff
>
>
> We should allow routines to take BOOLEAN arguments as part of our expanding support for the BOOLEAN datatype.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-4659) Allow routines to take arguments of
BOOLEAN type
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas closed DERBY-4659.
--------------------------------
> Allow routines to take arguments of BOOLEAN type
> ------------------------------------------------
>
> Key: DERBY-4659
> URL: https://issues.apache.org/jira/browse/DERBY-4659
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4659-01-aa-functionArgs.diff, derby-4659-02-aa-getFunctionColumns.diff, derby-4659-03-aa-procedureArgs.diff, derby-4659-03-ab-procedureArgs.diff
>
>
> We should allow routines to take BOOLEAN arguments as part of our expanding support for the BOOLEAN datatype.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4659) Allow routines to take arguments of
BOOLEAN type
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12880813#action_12880813 ]
Rick Hillegas commented on DERBY-4659:
--------------------------------------
Committed derby-4659-01-aa-functionArgs.diff at subversion revision 956563.
> Allow routines to take arguments of BOOLEAN type
> ------------------------------------------------
>
> Key: DERBY-4659
> URL: https://issues.apache.org/jira/browse/DERBY-4659
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4659-01-aa-functionArgs.diff
>
>
> We should allow routines to take BOOLEAN arguments as part of our expanding support for the BOOLEAN datatype.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4659) Allow routines to take arguments of
BOOLEAN type
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-4659:
---------------------------------
Attachment: derby-4659-03-ab-procedureArgs.diff
Attaching derby-4659-03-ab-procedureArgs.diff and committing it at subversion revision 957650.
Regression tests on the previous version of this patch passed cleanly except for the following issues:
1) Diffs in dblook_test_net and dblook_test_net_territory. These were caused by another patch and they were corrected by re-syncing with the corrected trunk.
2) An error in DatabaseMetaDataTest which surfaced when that test was run as part of the upgrade suite. The problem was that the test was creating a procedure with BOOLEAN args but this only works if the database has been upgraded to 10.7 or higher. I have conditionalized that code so that BOOLEAN args are only tested if the database is advanced enough. The test now runs cleanly both standalone and as part of the upgrade suite.
> Allow routines to take arguments of BOOLEAN type
> ------------------------------------------------
>
> Key: DERBY-4659
> URL: https://issues.apache.org/jira/browse/DERBY-4659
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4659-01-aa-functionArgs.diff, derby-4659-02-aa-getFunctionColumns.diff, derby-4659-03-aa-procedureArgs.diff, derby-4659-03-ab-procedureArgs.diff
>
>
> We should allow routines to take BOOLEAN arguments as part of our expanding support for the BOOLEAN datatype.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-4659) Allow routines to take arguments of
BOOLEAN type
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas reassigned DERBY-4659:
------------------------------------
Assignee: Rick Hillegas
> Allow routines to take arguments of BOOLEAN type
> ------------------------------------------------
>
> Key: DERBY-4659
> URL: https://issues.apache.org/jira/browse/DERBY-4659
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
>
> We should allow routines to take BOOLEAN arguments as part of our expanding support for the BOOLEAN datatype.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4659) Allow routines to take arguments of
BOOLEAN type
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-4659:
---------------------------------
Attachment: derby-4659-03-aa-procedureArgs.diff
Attaching derby-4659-03-aa-procedureArgs.diff. This patch enables BOOLEAN arguments to procedures. I need to run regression tests.
Touches the following files:
-----------
M java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
Parser change.
-----------
M java/engine/org/apache/derby/impl/sql/compile/MethodCallNode.java
M java/engine/org/apache/derby/impl/sql/compile/StaticMethodCallNode.java
Support for resolving procedures with out and inout BOOLEAN args.
-----------
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java
Regression test for DatabaseMetaData.getProcedureColumns().
-----------
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/ParameterMetaDataJdbc30Test.java
Regression test for ParameterMetaData and for setting and retrieving BOOLEAN args.
> Allow routines to take arguments of BOOLEAN type
> ------------------------------------------------
>
> Key: DERBY-4659
> URL: https://issues.apache.org/jira/browse/DERBY-4659
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4659-01-aa-functionArgs.diff, derby-4659-02-aa-getFunctionColumns.diff, derby-4659-03-aa-procedureArgs.diff
>
>
> We should allow routines to take BOOLEAN arguments as part of our expanding support for the BOOLEAN datatype.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4659) Allow routines to take arguments of
BOOLEAN type
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-4659:
---------------------------------
Attachment: derby-4659-01-aa-functionArgs.diff
Attaching derby-4659-01-aa-functionArgs.diff. This patch makes it possible for functions to take BOOLEAN arguments. The regression tests passed cleanly for me. After this patch, we can add a test for DatabaseMetaData.getFunctionColumns().
Touches the following files:
---------
M java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
Parser support for BOOLEAN function arguments.
---------
M java/client/org/apache/derby/client/am/PreparedStatement.java
Client driver support for setting BOOLEAN arguments.
---------
M java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/ParameterMetaDataJdbc30Test.java
ParameterMetaData test for BOOLEAN arguments.
---------
M java/testing/org/apache/derbyTesting/functionTests/tests/lang/BooleanValuesTest.java
Test for setting boolean arguments.
---------
M java/testing/org/apache/derbyTesting/functionTests/tests/lang/AnsiSignaturesTest.java
M java/testing/org/apache/derbyTesting/functionTests/tests/lang/AnsiSignatures.java
Test for function resolution.
> Allow routines to take arguments of BOOLEAN type
> ------------------------------------------------
>
> Key: DERBY-4659
> URL: https://issues.apache.org/jira/browse/DERBY-4659
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4659-01-aa-functionArgs.diff
>
>
> We should allow routines to take BOOLEAN arguments as part of our expanding support for the BOOLEAN datatype.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-4659) Allow routines to take arguments of
BOOLEAN type
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas resolved DERBY-4659.
----------------------------------
Resolution: Fixed
> Allow routines to take arguments of BOOLEAN type
> ------------------------------------------------
>
> Key: DERBY-4659
> URL: https://issues.apache.org/jira/browse/DERBY-4659
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4659-01-aa-functionArgs.diff, derby-4659-02-aa-getFunctionColumns.diff, derby-4659-03-aa-procedureArgs.diff, derby-4659-03-ab-procedureArgs.diff
>
>
> We should allow routines to take BOOLEAN arguments as part of our expanding support for the BOOLEAN datatype.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4659) Allow routines to take arguments of
BOOLEAN type
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-4659:
---------------------------------
Issue & fix info: [Patch Available]
> Allow routines to take arguments of BOOLEAN type
> ------------------------------------------------
>
> Key: DERBY-4659
> URL: https://issues.apache.org/jira/browse/DERBY-4659
> Project: Derby
> Issue Type: Improvement
> Components: SQL
> Reporter: Rick Hillegas
> Assignee: Rick Hillegas
> Attachments: derby-4659-01-aa-functionArgs.diff
>
>
> We should allow routines to take BOOLEAN arguments as part of our expanding support for the BOOLEAN datatype.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.