[I] sync-execution timeout misclassified as "Error" instead of "Killed" (wrapped TimeoutException) [texera]

["bobbai00 (via GitHub)" <gi...@apache.org>]

bobbai00 opened a new issue, #6198:
URL: https://github.com/apache/texera/issues/6198

   ### What happened?
   
   The synchronous workflow-execution endpoint (`SyncExecutionResource`) is supposed to return state `"Killed"` with a `"Timeout after N seconds"` error — and call `killExecution` — when a run exceeds its `timeoutSeconds`. Instead, a genuine timeout is **misclassified as a generic `"Error"`** and the execution is **not killed**.
   
   **Root cause.** The terminal wait is:
   
   ```scala
   Observable.amb(...).firstOrError().timeout(timeoutSeconds, SECONDS).blockingGet()
   ```
   
   `firstOrError()` yields a `Single`, and RxJava's `Single.blockingGet()` rethrows a failure via `ExceptionHelper.wrapOrThrow`, which **wraps the checked `java.util.concurrent.TimeoutException`** (thrown by `.timeout()`) **in a `RuntimeException`**. The catch clause matches on:
   
   ```scala
   case _: java.util.concurrent.TimeoutException => // Killed
   ```
   
   which never matches the wrapped exception, so control falls through to the generic `case e: Exception => // Error` branch.
   
   **Expected:** a timeout is detected (by unwrapping the cause chain), reported as `state = "Killed"` with `"Timeout after N seconds"`, and the execution is killed.
   
   ### How to reproduce?
   
   1. Submit a workflow to the sync-execution endpoint with a small `timeoutSeconds`.
   2. Ensure no terminal signal (completion / console-error / target-results) arrives before the timeout elapses.
   3. Observe the response: `state = "Error"` carrying the raw wrapped-exception message, instead of `state = "Killed"` / `"Timeout after N seconds"`; the execution is not killed.
   
   ### Version/Branch
   
   1.3.0-incubating-SNAPSHOT (main)
   
   ### Commit Hash (Optional)
   
   Present on `main`; the branch behavior is unchanged from the introduction of the `case _: TimeoutException` catch.
   
   ### Relevant log output
   
   _n/a — the timeout is silently reclassified as a generic error._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] sync-execution timeout misclassified as "Error" instead of "Killed" (wrapped TimeoutException) [texera]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on issue #6198:
URL: https://github.com/apache/texera/issues/6198#issuecomment-4887359070

   <!-- texera:template-compliance -->
   👋 Thanks for opening this issue, @bobbai00!
   
   It looks like the issue description doesn't quite follow our template yet:
   
   - This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
   
   Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
   
   You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] sync-execution timeout misclassified as "Error" instead of "Killed" (wrapped TimeoutException) [texera]

["anthonychengit (via GitHub)" <gi...@apache.org>]

anthonychengit commented on issue #6198:
URL: https://github.com/apache/texera/issues/6198#issuecomment-5287268911

   /take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org