You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/07/09 06:19:46 UTC
[GitHub] [calcite] Aaaaaaron opened a new pull request #2059: [CALCITE-4112] refine the usage of CalciteConnectionConfig in DecorrelateProgram.
Aaaaaaron opened a new pull request #2059:
URL: https://github.com/apache/calcite/pull/2059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2059: [CALCITE-4112] refine the usage of CalciteConnectionConfig in DecorrelateProgram (Jiatao Tao)
Posted by GitBox <gi...@apache.org>.
Aaaaaaron edited a comment on pull request #2059:
URL: https://github.com/apache/calcite/pull/2059#issuecomment-656454802
> Consider using `Util.first()`. Then the variable can stay `final`.
>
> Consider adding a constant `DEFAULT` in `CalciteConnectionConfigImpl`.
@julianhyde Thanks for your suggestion, revised.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] Aaaaaaron commented on pull request #2059: [CALCITE-4112] refine the usage of CalciteConnectionConfig in DecorrelateProgram (Jiatao Tao)
Posted by GitBox <gi...@apache.org>.
Aaaaaaron commented on pull request #2059:
URL: https://github.com/apache/calcite/pull/2059#issuecomment-656454802
> Consider using `Util.first()`. Then the variable can stay `final`.
>
> Consider adding a constant `DEFAULT` in `CalciteConnectionConfigImpl`.
Thanks for your suggestion, revised.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] julianhyde commented on pull request #2059: [CALCITE-4112] refine the usage of CalciteConnectionConfig in DecorrelateProgram.
Posted by GitBox <gi...@apache.org>.
julianhyde commented on pull request #2059:
URL: https://github.com/apache/calcite/pull/2059#issuecomment-656284696
Commit messages should start with a capital letter, not end with '.', and should end with your name in parentheses if you are not a committer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] Aaaaaaron commented on pull request #2059: [CALCITE-4112] refine the usage of CalciteConnectionConfig in DecorrelateProgram (Jiatao Tao)
Posted by GitBox <gi...@apache.org>.
Aaaaaaron commented on pull request #2059:
URL: https://github.com/apache/calcite/pull/2059#issuecomment-657070136
@julianhyde I've revised my PR, would you please take a look ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] Aaaaaaron commented on pull request #2059: [CALCITE-4112] refine the usage of CalciteConnectionConfig in DecorrelateProgram (Jiatao Tao)
Posted by GitBox <gi...@apache.org>.
Aaaaaaron commented on pull request #2059:
URL: https://github.com/apache/calcite/pull/2059#issuecomment-656454903
> Commit messages should start with a capital letter, not end with '.', and should end with your name in parentheses if you are not a committer.
@julianhyde Thanks for your suggestion, revised.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] DonnyZone merged pull request #2059: [CALCITE-4112] Refine the usage of CalciteConnectionConfig in DecorrelateProgram (Jiatao Tao)
Posted by GitBox <gi...@apache.org>.
DonnyZone merged pull request #2059:
URL: https://github.com/apache/calcite/pull/2059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] DonnyZone commented on pull request #2059: [CALCITE-4112] Refine the usage of CalciteConnectionConfig in DecorrelateProgram (Jiatao Tao)
Posted by GitBox <gi...@apache.org>.
DonnyZone commented on pull request #2059:
URL: https://github.com/apache/calcite/pull/2059#issuecomment-657932487
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] julianhyde commented on pull request #2059: [CALCITE-4112] refine the usage of CalciteConnectionConfig in DecorrelateProgram.
Posted by GitBox <gi...@apache.org>.
julianhyde commented on pull request #2059:
URL: https://github.com/apache/calcite/pull/2059#issuecomment-656286196
Consider using `Util.first()`. Then the variable can stay `final`.
Consider adding a constant `DEFAULT` in `CalciteConnectionConfigImpl`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org