You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/04/24 14:35:42 UTC

[GitHub] [arrow] wgtmac commented on a diff in pull request #35298: GH-35297: [C++][IPC] Fix schema deserialization of map field

wgtmac commented on code in PR #35298:
URL: https://github.com/apache/arrow/pull/35298#discussion_r1175382767


##########
cpp/src/arrow/ipc/read_write_test.cc:
##########
@@ -271,6 +280,29 @@ TEST_F(TestSchemaMetadata, NestedFields) {
   CheckSchemaRoundtrip(schema);
 }
 
+// Verify that nullable=false is well-preserved for child fields of map type.
+TEST_F(TestSchemaMetadata, MapField) {
+  auto key = field("key", int32(), false);
+  auto item = field("item", int32(), false);

Review Comment:
   You may reproduce the bug with this test case without the fix. @lidavidm 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org