[GitHub] [apr] wrowe commented on a change in pull request #34: Fix a rare segfault in apr_global_mutex_child_init()

[GitBox <gi...@apache.org>]

wrowe commented on a change in pull request #34:
URL: https://github.com/apache/apr/pull/34#discussion_r827131241



##########
File path: locks/unix/global_mutex.c
##########
@@ -86,6 +86,10 @@ APR_DECLARE(apr_status_t) apr_global_mutex_child_init(
 {
     apr_status_t rv;
 
+    if (*mutex == NULL) {
+        return APR_ENOLOCK;
+    }
+

Review comment:
       This looks to me like an APR contract change, that we should docx the new return code and suggest to the author they can set up the appropriate retry schema, and put it back on mod_isapi.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org