You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by taojoe <gi...@git.apache.org> on 2015/05/05 18:24:52 UTC
[GitHub] thrift pull request: make generated js file strict mode for nodejs
GitHub user taojoe opened a pull request:
https://github.com/apache/thrift/pull/480
make generated js file strict mode for nodejs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/taojoe/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/480.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #480
----
commit 75800eff2d04a4e970efc2161f0c9c2b14e083f2
Author: joe <ta...@gmail.com>
Date: 2015-05-05T16:21:50Z
make generated js file strict mode for nodejs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #480: make generated js file strict mode for nodejs
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/480
@jfarrell this PR can be closed. It never got a Jira ticket and from the comments above didn't work properly, and hasn't been updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #480: make generated js file strict mode for nodejs
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/480
---
[GitHub] thrift pull request: make generated js file strict mode for nodejs
Posted by henrique <gi...@git.apache.org>.
Github user henrique commented on the pull request:
https://github.com/apache/thrift/pull/480#issuecomment-101795809
Thanks for the PR but this causes a syntax error:
```
./thrift/lib/nodejs/test/gen-nodejs/ThriftTest.js:14
var ThriftTest.ThriftTest_testVoid_args = function(args) {
^
SyntaxError: Unexpected token .
```
Please read https://github.com/apache/thrift/blob/master/CONTRIBUTING.md and resubmit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: make generated js file strict mode for nodejs
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/480#issuecomment-140595062
@taojoe thanks for the patch, appreciate the help. Would you mind creating a ticket for this in our jira
http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---