You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2015/06/16 17:02:45 UTC
[Bug 58042] New: SlowQueryReport failed query logging
https://bz.apache.org/bugzilla/show_bug.cgi?id=58042
Bug ID: 58042
Summary: SlowQueryReport failed query logging
Product: Tomcat 8
Version: trunk
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: kwill806@gmail.com
The SlowQueryReport JDBC interceptor catches Exceptions, by default logs them,
and rethrows them. There is an option with the latest version not to write the
message to the log, but it still sends it to JMX. It is very common in
enterprise frameworks (such as Spring JDBC) to call a method, catch any
exception thrown and handle the exception. All of this is normal activity. It
should not be logged, it should not be sent to JMX. So first I would argue that
SlowQueryReport SHOULD NOT log failed SQL statements at all. It is not
documented as such, and it is a pain in the ??? that it does. :-) Second, it
you will not remove the functionality, please understand that JMX and logging
should "log" the same actions. So the setting should effect both. But again, if
you want to make it hard to configure, by all means create yet another setting
to control sending failed SQL to JMX. Finally, if you will not remove the
functionality, please change the default to NOT log failed SQL. Minimal
configuration is best. :-)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 58042] SlowQueryReport failed query logging
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58042
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Catalina |jdbc-pool
OS| |All
Version|trunk |unspecified
Product|Tomcat 8 |Tomcat Modules
Target Milestone|---- |---
--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Correct component
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 58042] SlowQueryReport failed query logging
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58042
--- Comment #2 from Keiichi Fujino <kf...@apache.org> ---
Thanks for the report.
I fixed to use the LogSlow attribute and the logFailed attribute as a condition
to send JMX notifications.(r1688164)
As for default value of the logFailed attribute, I will change to false against
trunk and tc8.0 unless there is no objections.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 58042] SlowQueryReport failed query logging
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58042
Keiichi Fujino <kf...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Keiichi Fujino <kf...@apache.org> ---
Fixed r1692049, r1692050.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org