You are viewing a plain text version of this content. The canonical link for it is here.
Posted to woden-dev@ws.apache.org by "John Kaputin (JIRA)" <ji...@apache.org> on 2007/08/15 15:31:31 UTC
[jira] Created: (WODEN-179) Remove WSDLReader.readWSDL methods that
take an ErrorHandler parameter
Remove WSDLReader.readWSDL methods that take an ErrorHandler parameter
----------------------------------------------------------------------
Key: WODEN-179
URL: https://issues.apache.org/jira/browse/WODEN-179
Project: Woden
Issue Type: Improvement
Reporter: John Kaputin
Fix For: M8
Each type of readWSDL method (i.e. URI argument, WSDLSource arg) also offers a signature that takes an ErrorHandler object. ErrorHandler is just one type of user configuration that may be done via the WSDLReader. Others include setting the ExtensionRegistry and URIResolver. It seems inconsistent to offer ErrorHandler configuration via the readWSDL methods, while explicit setters are used for the others. I think I did this originally as a convenience method, but I prefer a programming model that preserves the encapsulation of ErrorReporter and maintains a consistent approach across the WSDLReader API.
This means the client would code:
reader.getErrorReporter().setErrorHandler(myErrHandler);
reader.readWSDL(wsdlUri);
rather than:
reader.readWSDL(wsdlUri, myErrHandler);
A slightly longer pgm model, but better encapsulation and with the improved scoping of share objects brought about by WODEN-177, it becomes more obvious that this configuration change is a persistent change to the ErrorReporter, hence scoped across Woden, not just a temporary change for the life if the readWSDL invocation.
The readWSDL methods in question are not used by Axis2, so I'd prefer to remove them rather than deprecate across releases, but we should post to the woden-dev list to see if there are any objections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Updated: (WODEN-179) Remove WSDLReader.readWSDL methods that
take an ErrorHandler parameter
Posted by "Dan Harvey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Harvey updated WODEN-179:
-----------------------------
Attachment: woden-179.patch
> Remove WSDLReader.readWSDL methods that take an ErrorHandler parameter
> ----------------------------------------------------------------------
>
> Key: WODEN-179
> URL: https://issues.apache.org/jira/browse/WODEN-179
> Project: Woden
> Issue Type: Improvement
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
> Attachments: woden-179.patch
>
>
> Each type of readWSDL method (i.e. URI argument, WSDLSource arg) also offers a signature that takes an ErrorHandler object. ErrorHandler is just one type of user configuration that may be done via the WSDLReader. Others include setting the ExtensionRegistry and URIResolver. It seems inconsistent to offer ErrorHandler configuration via the readWSDL methods, while explicit setters are used for the others. I think I did this originally as a convenience method, but I prefer a programming model that preserves the encapsulation of ErrorReporter and maintains a consistent approach across the WSDLReader API.
> This means the client would code:
> reader.getErrorReporter().setErrorHandler(myErrHandler);
> reader.readWSDL(wsdlUri);
> rather than:
> reader.readWSDL(wsdlUri, myErrHandler);
> A slightly longer pgm model, but better encapsulation and with the improved scoping of share objects brought about by WODEN-177, it becomes more obvious that this configuration change is a persistent change to the ErrorReporter, hence scoped across Woden, not just a temporary change for the life if the readWSDL invocation.
> The readWSDL methods in question are not used by Axis2, so I'd prefer to remove them rather than deprecate across releases, but we should post to the woden-dev list to see if there are any objections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Closed: (WODEN-179) Remove WSDLReader.readWSDL methods that
take an ErrorHandler parameter
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin closed WODEN-179.
------------------------------
> Remove WSDLReader.readWSDL methods that take an ErrorHandler parameter
> ----------------------------------------------------------------------
>
> Key: WODEN-179
> URL: https://issues.apache.org/jira/browse/WODEN-179
> Project: Woden
> Issue Type: Improvement
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
> Attachments: woden-179.patch
>
>
> Each type of readWSDL method (i.e. URI argument, WSDLSource arg) also offers a signature that takes an ErrorHandler object. ErrorHandler is just one type of user configuration that may be done via the WSDLReader. Others include setting the ExtensionRegistry and URIResolver. It seems inconsistent to offer ErrorHandler configuration via the readWSDL methods, while explicit setters are used for the others. I think I did this originally as a convenience method, but I prefer a programming model that preserves the encapsulation of ErrorReporter and maintains a consistent approach across the WSDLReader API.
> This means the client would code:
> reader.getErrorReporter().setErrorHandler(myErrHandler);
> reader.readWSDL(wsdlUri);
> rather than:
> reader.readWSDL(wsdlUri, myErrHandler);
> A slightly longer pgm model, but better encapsulation and with the improved scoping of share objects brought about by WODEN-177, it becomes more obvious that this configuration change is a persistent change to the ErrorReporter, hence scoped across Woden, not just a temporary change for the life if the readWSDL invocation.
> The readWSDL methods in question are not used by Axis2, so I'd prefer to remove them rather than deprecate across releases, but we should post to the woden-dev list to see if there are any objections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-179) Remove WSDLReader.readWSDL methods
that take an ErrorHandler parameter
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546264 ]
John Kaputin commented on WODEN-179:
------------------------------------
Axis2 is not affected by this code change. ServiceMix have responded that they will update their code if necessary after this change is made. Woden4SAWSDL is based on a modified copy of the M7a release, so it will not be broken by this change to Woden trunk.
> Remove WSDLReader.readWSDL methods that take an ErrorHandler parameter
> ----------------------------------------------------------------------
>
> Key: WODEN-179
> URL: https://issues.apache.org/jira/browse/WODEN-179
> Project: Woden
> Issue Type: Improvement
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
> Attachments: woden-179.patch
>
>
> Each type of readWSDL method (i.e. URI argument, WSDLSource arg) also offers a signature that takes an ErrorHandler object. ErrorHandler is just one type of user configuration that may be done via the WSDLReader. Others include setting the ExtensionRegistry and URIResolver. It seems inconsistent to offer ErrorHandler configuration via the readWSDL methods, while explicit setters are used for the others. I think I did this originally as a convenience method, but I prefer a programming model that preserves the encapsulation of ErrorReporter and maintains a consistent approach across the WSDLReader API.
> This means the client would code:
> reader.getErrorReporter().setErrorHandler(myErrHandler);
> reader.readWSDL(wsdlUri);
> rather than:
> reader.readWSDL(wsdlUri, myErrHandler);
> A slightly longer pgm model, but better encapsulation and with the improved scoping of share objects brought about by WODEN-177, it becomes more obvious that this configuration change is a persistent change to the ErrorReporter, hence scoped across Woden, not just a temporary change for the life if the readWSDL invocation.
> The readWSDL methods in question are not used by Axis2, so I'd prefer to remove them rather than deprecate across releases, but we should post to the woden-dev list to see if there are any objections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Assigned: (WODEN-179) Remove WSDLReader.readWSDL methods
that take an ErrorHandler parameter
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin reassigned WODEN-179:
----------------------------------
Assignee: Dan Harvey
> Remove WSDLReader.readWSDL methods that take an ErrorHandler parameter
> ----------------------------------------------------------------------
>
> Key: WODEN-179
> URL: https://issues.apache.org/jira/browse/WODEN-179
> Project: Woden
> Issue Type: Improvement
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
>
> Each type of readWSDL method (i.e. URI argument, WSDLSource arg) also offers a signature that takes an ErrorHandler object. ErrorHandler is just one type of user configuration that may be done via the WSDLReader. Others include setting the ExtensionRegistry and URIResolver. It seems inconsistent to offer ErrorHandler configuration via the readWSDL methods, while explicit setters are used for the others. I think I did this originally as a convenience method, but I prefer a programming model that preserves the encapsulation of ErrorReporter and maintains a consistent approach across the WSDLReader API.
> This means the client would code:
> reader.getErrorReporter().setErrorHandler(myErrHandler);
> reader.readWSDL(wsdlUri);
> rather than:
> reader.readWSDL(wsdlUri, myErrHandler);
> A slightly longer pgm model, but better encapsulation and with the improved scoping of share objects brought about by WODEN-177, it becomes more obvious that this configuration change is a persistent change to the ErrorReporter, hence scoped across Woden, not just a temporary change for the life if the readWSDL invocation.
> The readWSDL methods in question are not used by Axis2, so I'd prefer to remove them rather than deprecate across releases, but we should post to the woden-dev list to see if there are any objections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Resolved: (WODEN-179) Remove WSDLReader.readWSDL methods
that take an ErrorHandler parameter
Posted by "John Kaputin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Kaputin resolved WODEN-179.
--------------------------------
Resolution: Fixed
r599061
Fixed by applying Dan Harvey's patch.
> Remove WSDLReader.readWSDL methods that take an ErrorHandler parameter
> ----------------------------------------------------------------------
>
> Key: WODEN-179
> URL: https://issues.apache.org/jira/browse/WODEN-179
> Project: Woden
> Issue Type: Improvement
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
> Attachments: woden-179.patch
>
>
> Each type of readWSDL method (i.e. URI argument, WSDLSource arg) also offers a signature that takes an ErrorHandler object. ErrorHandler is just one type of user configuration that may be done via the WSDLReader. Others include setting the ExtensionRegistry and URIResolver. It seems inconsistent to offer ErrorHandler configuration via the readWSDL methods, while explicit setters are used for the others. I think I did this originally as a convenience method, but I prefer a programming model that preserves the encapsulation of ErrorReporter and maintains a consistent approach across the WSDLReader API.
> This means the client would code:
> reader.getErrorReporter().setErrorHandler(myErrHandler);
> reader.readWSDL(wsdlUri);
> rather than:
> reader.readWSDL(wsdlUri, myErrHandler);
> A slightly longer pgm model, but better encapsulation and with the improved scoping of share objects brought about by WODEN-177, it becomes more obvious that this configuration change is a persistent change to the ErrorReporter, hence scoped across Woden, not just a temporary change for the life if the readWSDL invocation.
> The readWSDL methods in question are not used by Axis2, so I'd prefer to remove them rather than deprecate across releases, but we should post to the woden-dev list to see if there are any objections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org
[jira] Commented: (WODEN-179) Remove WSDLReader.readWSDL methods
that take an ErrorHandler parameter
Posted by "Lawrence Mandel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WODEN-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527824 ]
Lawrence Mandel commented on WODEN-179:
---------------------------------------
I think this is the right approach wrt the method signature.
WRT deprecating, because there is an equivalent alternative and we have not yet had a release I think we're OK to remove the method signature at this point without deprecating. (Normally I think we should deprecate for at least one milestone - and this cannot be the convention after Woden has had a release and declared API.) However, this needs to be documented in the release notes and we need to give the Woden community ample time to review and comment. I suggest reposting to the list with a subject prefix such as [breaking change] to ensure the message is flagged to adopters.
Thanks for checking that this change won't break Axis2. Can you also check with the other two known Woden adopters listed at [1]?
[1] http://incubator.apache.org/woden/projectsusingwoden.html
> Remove WSDLReader.readWSDL methods that take an ErrorHandler parameter
> ----------------------------------------------------------------------
>
> Key: WODEN-179
> URL: https://issues.apache.org/jira/browse/WODEN-179
> Project: Woden
> Issue Type: Improvement
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
>
> Each type of readWSDL method (i.e. URI argument, WSDLSource arg) also offers a signature that takes an ErrorHandler object. ErrorHandler is just one type of user configuration that may be done via the WSDLReader. Others include setting the ExtensionRegistry and URIResolver. It seems inconsistent to offer ErrorHandler configuration via the readWSDL methods, while explicit setters are used for the others. I think I did this originally as a convenience method, but I prefer a programming model that preserves the encapsulation of ErrorReporter and maintains a consistent approach across the WSDLReader API.
> This means the client would code:
> reader.getErrorReporter().setErrorHandler(myErrHandler);
> reader.readWSDL(wsdlUri);
> rather than:
> reader.readWSDL(wsdlUri, myErrHandler);
> A slightly longer pgm model, but better encapsulation and with the improved scoping of share objects brought about by WODEN-177, it becomes more obvious that this configuration change is a persistent change to the ErrorReporter, hence scoped across Woden, not just a temporary change for the life if the readWSDL invocation.
> The readWSDL methods in question are not used by Axis2, so I'd prefer to remove them rather than deprecate across releases, but we should post to the woden-dev list to see if there are any objections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org