You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/12/25 20:32:12 UTC

[I] Prepare code with Scala 3.4 by dropping `private[this]` [incubator-pekko]

He-Pin opened a new issue, #880:
URL: https://github.com/apache/incubator-pekko/issues/880

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Prepare code with Scala 3.4 by dropping `private[this]` [incubator-pekko]

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #880:
URL: https://github.com/apache/incubator-pekko/issues/880#issuecomment-1869125600

   Agree with @pjfanning here, core Pekko modules will never support Scala 3.4 (its not an LTS release) and there may be issues with the removal of `private[this]`.
   
   We should only start looking into this when the next Scala LTS is being considered, which is likely to be many many many years away.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [I] Prepare code with Scala 3.4 by dropping `private[this]` [incubator-pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #880:
URL: https://github.com/apache/incubator-pekko/issues/880#issuecomment-1869111106

   Scala 3.4 is not LTS and Scala 3.4 compiled code won't work for Scala 3.3 users. So I don't think we'll be compiling with Scala 3.4 any time soon.
   
   Setting up a build that compiles with tests Scala 3.3 generated classes with Scala 3.4 runtime seems more useful to me.
   
   Removing `private[this]` will have a big impact on our Scala 2 support and Scala 3.3 support.
   
   For me, this should be delayed till at least after Pekko 1.1.0 release. Testing but not compiling with Scala 3.4 could be done earlier.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org