You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shahar1 (via GitHub)" <gi...@apache.org> on 2024/03/11 19:49:17 UTC
[PR] Rename `SparkSubmitOperator`'s fields' names to comply with templated fields validation [airflow]
shahar1 opened a new pull request, #38051:
URL: https://github.com/apache/airflow/pull/38051
related: #36484
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename `SparkSubmitOperator`/`SparkJDBCOperator` fields' names to comply with templated fields validation [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #38051:
URL: https://github.com/apache/airflow/pull/38051#discussion_r1527143611
##########
airflow/providers/apache/spark/operators/spark_jdbc.py:
##########
@@ -44,14 +44,6 @@ class SparkJDBCOperator(SparkSubmitOperator):
:param spark_files: Additional files to upload to the container running the job
:param spark_jars: Additional jars to upload and add to the driver and
executor classpath
- :param num_executors: number of executor to run. This should be set so as to manage
- the number of connections made with the JDBC database
- :param executor_cores: Number of cores per executor
- :param executor_memory: Memory per executor (e.g. 1000M, 2G)
- :param driver_memory: Memory allocated to the driver (e.g. 1000M, 2G)
- :param verbose: Whether to pass the verbose flag to spark-submit for debugging
- :param keytab: Full path to the file that contains the keytab
- :param principal: The name of the kerberos principal used for keytab
Review Comment:
cool thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename `SparkSubmitOperator`'s fields' names to comply with templated fields validation [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #38051:
URL: https://github.com/apache/airflow/pull/38051#discussion_r1520732720
##########
airflow/providers/apache/spark/operators/spark_jdbc.py:
##########
@@ -162,6 +165,25 @@ def __init__(
self._hook: SparkJDBCHook | None = None
self._use_krb5ccache = use_krb5ccache
+ @property
+ @deprecated(
+ reason="`_keytab` is deprecated and will be removed in the future. Please use `keytab` instead.",
Review Comment:
It is not strictly required to deprecate internal/private methods. We could just remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename `SparkSubmitOperator`/`SparkJDBCOperator` fields' names to comply with templated fields validation [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #38051:
URL: https://github.com/apache/airflow/pull/38051#discussion_r1527140569
##########
airflow/providers/apache/spark/operators/spark_jdbc.py:
##########
@@ -44,14 +44,6 @@ class SparkJDBCOperator(SparkSubmitOperator):
:param spark_files: Additional files to upload to the container running the job
:param spark_jars: Additional jars to upload and add to the driver and
executor classpath
- :param num_executors: number of executor to run. This should be set so as to manage
- the number of connections made with the JDBC database
- :param executor_cores: Number of cores per executor
- :param executor_memory: Memory per executor (e.g. 1000M, 2G)
- :param driver_memory: Memory allocated to the driver (e.g. 1000M, 2G)
- :param verbose: Whether to pass the verbose flag to spark-submit for debugging
- :param keytab: Full path to the file that contains the keytab
- :param principal: The name of the kerberos principal used for keytab
Review Comment:
All of these params exist already in the parent, so to avoid repetition, we could treat them in the `**kwargs` passed to `super().__init__(...)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename `SparkSubmitOperator`/`SparkJDBCOperator` fields' names to comply with templated fields validation [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #38051:
URL: https://github.com/apache/airflow/pull/38051#issuecomment-1999934890
> There are conflicts :(
Fixed; it's expected as we remove an entry in each PR from `.pre-commit-config.yaml`, and sometimes GIT can't resolve it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename `SparkSubmitOperator`'s fields' names to comply with templated fields validation [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #38051:
URL: https://github.com/apache/airflow/pull/38051#discussion_r1520732720
##########
airflow/providers/apache/spark/operators/spark_jdbc.py:
##########
@@ -162,6 +165,25 @@ def __init__(
self._hook: SparkJDBCHook | None = None
self._use_krb5ccache = use_krb5ccache
+ @property
+ @deprecated(
+ reason="`_keytab` is deprecated and will be removed in the future. Please use `keytab` instead.",
Review Comment:
It is not strictly required to deprecate internal/private methods/attributes. We could just remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename `SparkSubmitOperator`/`SparkJDBCOperator` fields' names to comply with templated fields validation [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #38051:
URL: https://github.com/apache/airflow/pull/38051#discussion_r1527138900
##########
airflow/providers/apache/spark/operators/spark_jdbc.py:
##########
@@ -44,14 +44,6 @@ class SparkJDBCOperator(SparkSubmitOperator):
:param spark_files: Additional files to upload to the container running the job
:param spark_jars: Additional jars to upload and add to the driver and
executor classpath
- :param num_executors: number of executor to run. This should be set so as to manage
- the number of connections made with the JDBC database
- :param executor_cores: Number of cores per executor
- :param executor_memory: Memory per executor (e.g. 1000M, 2G)
- :param driver_memory: Memory allocated to the driver (e.g. 1000M, 2G)
- :param verbose: Whether to pass the verbose flag to spark-submit for debugging
- :param keytab: Full path to the file that contains the keytab
- :param principal: The name of the kerberos principal used for keytab
Review Comment:
Why are these removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename `SparkSubmitOperator`/`SparkJDBCOperator` fields' names to comply with templated fields validation [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #38051:
URL: https://github.com/apache/airflow/pull/38051#issuecomment-1999922501
There are conflicts :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename `SparkSubmitOperator`/`SparkJDBCOperator` fields' names to comply with templated fields validation [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #38051:
URL: https://github.com/apache/airflow/pull/38051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org