You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/06 11:20:11 UTC

[GitHub] [airflow] TobKed opened a new pull request #7076: [AIRFLOW-6484] BigQuery hook - standardize handling http exceptions

TobKed opened a new pull request #7076: [AIRFLOW-6484] BigQuery hook - standardize handling http exceptions
URL: https://github.com/apache/airflow/pull/7076
 
 
   (missing)
   
   ---
   Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6484
   
   - [x] Description above provides context of the change
   - [x] Commit message starts with `[AIRFLOW-NNNN]`, where AIRFLOW-NNNN = JIRA ID*
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   (*) For document-only changes, no JIRA issue is needed. Commit message starts `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk merged pull request #7076: [AIRFLOW-6484] BigQuery hook - standardize handling http exceptions

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7076: [AIRFLOW-6484] BigQuery hook - standardize handling http exceptions
URL: https://github.com/apache/airflow/pull/7076
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7076: [AIRFLOW-6484] BigQuery hook - standardize handling http exceptions

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7076: [AIRFLOW-6484] BigQuery hook - standardize handling http exceptions
URL: https://github.com/apache/airflow/pull/7076#issuecomment-571114041
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=h1) Report
   > Merging [#7076](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9967486be28f79309aa4f31229e1c8785374cb53?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7076/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7076      +/-   ##
   ==========================================
   - Coverage   85.01%   84.72%   -0.29%     
   ==========================================
     Files         680      680              
     Lines       38748    38753       +5     
   ==========================================
   - Hits        32940    32835     -105     
   - Misses       5808     5918     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `88.38% <66.66%> (+0.03%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5) | `89.74% <0%> (+0.41%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=footer). Last update [9967486...ea12d4c](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7076: [AIRFLOW-6484] BigQuery hook - standardize handling http exceptions

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7076: [AIRFLOW-6484] BigQuery hook - standardize handling http exceptions
URL: https://github.com/apache/airflow/pull/7076#issuecomment-571114041
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=h1) Report
   > Merging [#7076](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9967486be28f79309aa4f31229e1c8785374cb53?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7076/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7076      +/-   ##
   ==========================================
   - Coverage   85.01%   84.72%   -0.29%     
   ==========================================
     Files         680      680              
     Lines       38748    38753       +5     
   ==========================================
   - Hits        32940    32835     -105     
   - Misses       5808     5918     +110
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `88.38% <66.66%> (+0.03%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
   | [airflow/jobs/local\_task\_job.py](https://codecov.io/gh/apache/airflow/pull/7076/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2xvY2FsX3Rhc2tfam9iLnB5) | `89.74% <0%> (+0.41%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=footer). Last update [9967486...ea12d4c](https://codecov.io/gh/apache/airflow/pull/7076?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services