You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Chris M. Hostetter (Jira)" <ji...@apache.org> on 2020/01/08 18:34:00 UTC

[jira] [Created] (SOLR-14180) RequestHandlerBase.java:227 assertion failing: not all "Tragix" exceptions have 500 status

Chris M. Hostetter created SOLR-14180:
-----------------------------------------

             Summary: RequestHandlerBase.java:227 assertion failing: not all "Tragix" exceptions have 500 status
                 Key: SOLR-14180
                 URL: https://issues.apache.org/jira/browse/SOLR-14180
             Project: Solr
          Issue Type: Bug
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: Chris M. Hostetter


RequestHandlerBase.java currently contains the following code added by SOLR-12477 ...

{code}
    } catch (Exception e) {
      if (req.getCore() != null) {
        boolean isTragic = req.getCore().getCoreContainer().checkTragicException(req.getCore());
        if (isTragic) {
          if (e instanceof SolrException) {
            // Tragic exceptions should always throw a server error
            assert ((SolrException) e).code() == 500;
          } else {
            // wrap it in a solr exception
            e = new SolrException(SolrException.ErrorCode.SERVER_ERROR, e.getMessage(), e);
          }
        }
      }
{code}

...however recent test failures have surfaced situations where this is evidnetly not true, and instead of the "original" error being returned to clients, the assertion fails, masking the "real" failure.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org