[GitHub] [geode] upthewaterspout commented on issue #2491: GEODE-3: fix analyzeDataSerializable for java9 and above

["upthewaterspout (GitHub)" <gi...@apache.org>]

It's not clear to me how a developer is supposed to maintain these lists going forward. Now if I touch any of these classes I have to run this test with two different versions of Java? Since this test seems to be here to fail whenever the developer changes one of these methods, maybe we should just skip the test for java 9 and above?

An alternative would be to stop doing this bytecode comparison and actually execute the toData and fromData methods. There is some complication there in how we populate the object in the first place, but if we actually put the work in we might be able to have much better tests of serialization compatibility.

[ Full content available at: https://github.com/apache/geode/pull/2491 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org