[GitHub] [spark] HyukjinKwon opened a new pull request #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes

[GitBox <gi...@apache.org>]

HyukjinKwon opened a new pull request #26898: [SPARK-30200][SQL][FOLLOW-UP] Expose only explain(mode: String) in Scala side, and clean up related codes
URL: https://github.com/apache/spark/pull/26898
 
 
   ### What changes were proposed in this pull request?
   
   This PR mainly targets:
   
   1. Expose only explain(mode: String) in Scala side
   2. Clean up related codes
       - Hide `ExplainMode` under private `execution` package. No particular reason but just because `ExplainUtils` exists there
       - Use `case object` + `trait` pattern in `ExplainMode` to look after `ParseMode`.
       -  Move `Dataset.toExplainString` to `QueryExecution.explainString` to look after `QueryExecution.simpleString`, and deduplicate the codes at `ExplainCommand`.
       - Use `ExplainMode` in `ExplainCommand` too.
       - Add `explainString` to `PythonSQLUtils` to avoid unexpected test failure of PySpark during refactoring Scala codes side.
   
   ### Why are the changes needed?
   
   To minimised exposed APIs, deduplicate, and clean up.
   
   ### Does this PR introduce any user-facing change?
   
   `Dataset.explain(mode: ExplainMode)` will be removed (which only exists in master).
   
   ### How was this patch tested?
   
   Manually tested and existing tests should cover.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org