[GitHub] [solr] HoustonPutman commented on a diff in pull request #1269: SOLR-16607: org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

[GitBox <gi...@apache.org>]

HoustonPutman commented on code in PR #1269:
URL: https://github.com/apache/solr/pull/1269#discussion_r1061617583


##########
solr/modules/hadoop-auth/src/test/org/apache/solr/security/hadoop/KerberosTestServices.java:
##########
@@ -198,10 +198,18 @@ public AppConfigurationEntry[] getAppConfigurationEntry(String name) {
    * These Locales don't generate dates that are compatible with Hadoop MiniKdc. See LocaleTest.java
    * and https://issues.apache.org/jira/browse/DIRKRB-753
    */
-  static final List<String> incompatibleLanguagesWithMiniKdc =
-      Arrays.asList(
-          "mzn", "ps", "mr", "uz", "ks", "bn", "my", "sd", "pa", "ar", "th", "dz", "ja", "ne",
-          "ckb", "fa", "lrc", "ur", "ig", "sat", "mni", "sa", "as");
+  static final List<String> incompatibleLanguagesWithMiniKdc = getIncompatibleLanguagesWithMiniKdc();
+
+  private static List<String> getIncompatibleLanguagesWithMiniKdc() {
+    List<String> locales = Arrays.asList(
+        "mzn", "ps", "mr", "uz", "ks", "bn", "my", "sd", "pa", "ar", "th", "dz", "ja", "ne",
+        "ckb", "fa", "lrc", "ur", "ig", "sat", "mni", "sa", "as");
+    if (Runtime.version().feature() >= 20) {

Review Comment:
   If these locales don't exist in `<20`, then do we need this check, I imagine it would be safe to add them to the list in all cases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org