[GitHub] [shardingsphere] taojintianxia commented on a diff in pull request #20021: Refactor : transfer all container related config files to env module

[GitBox <gi...@apache.org>]

taojintianxia commented on code in PR #20021:
URL: https://github.com/apache/shardingsphere/pull/20021#discussion_r941943686


##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-env/src/test/java/org/apache/shardingsphere/test/integration/env/container/atomic/storage/DockerStorageContainer.java:
##########
@@ -50,14 +50,17 @@ public abstract class DockerStorageContainer extends DockerITContainer implement
     @Getter(AccessLevel.NONE)
     private final String scenario;
     
+    private final String module;
+    
     private final Map<String, DataSource> actualDataSourceMap;
     
     private final Map<String, DataSource> expectedDataSourceMap;
     
-    public DockerStorageContainer(final DatabaseType databaseType, final String dockerImageName, final String scenario) {
+    public DockerStorageContainer(final DatabaseType databaseType, final String dockerImageName, final String scenario, final String module) {

Review Comment:
   this is not a replacement, it's polymorphism. what I thought is refactor scaling and then refactor transaction, finally refactor suite. if we merge module and scenario now, this will affect too much.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org