You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Chad Schoettger (JIRA)" <de...@beehive.apache.org> on 2005/11/17 22:12:45 UTC
[jira] Created: (BEEHIVE-1010) AptControlInterface does not detect errors from a custom control checker
AptControlInterface does not detect errors from a custom control checker
------------------------------------------------------------------------
Key: BEEHIVE-1010
URL: http://issues.apache.org/jira/browse/BEEHIVE-1010
Project: Beehive
Type: Bug
Components: Controls
Versions: V1
Reporter: Chad Schoettger
Assigned to: Chad Schoettger
The AptControlInterface class has no way to determine if a custom checker has found errors. This causes the TwoPhaseAnnotation processor to go ahead and start its generate phase instead of stopping processing. As a side effect of this behavior the checker is also invoked during the generate phase and issues duplicate error messages to the ones it issued from the check phase.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-1010) AptControlInterface does not detect errors from a custom control checker
Posted by "Chad Schoettger (JIRA)" <de...@beehive.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-1010?page=all ]
Chad Schoettger resolved BEEHIVE-1010:
--------------------------------------
Resolution: Fixed
Assign To: Jacob Danner (was: Chad Schoettger)
Ignore the patch file I attached to this bug the final fix was a bit different. The public interface for a control checker did NOT change.
> AptControlInterface does not detect errors from a custom control checker
> ------------------------------------------------------------------------
>
> Key: BEEHIVE-1010
> URL: http://issues.apache.org/jira/browse/BEEHIVE-1010
> Project: Beehive
> Type: Bug
> Components: Controls
> Versions: V1
> Reporter: Chad Schoettger
> Assignee: Jacob Danner
> Attachments: BEEHIVE-1010.patch, beehive-1010.zip
>
> The AptControlInterface class has no way to determine if a custom checker has found errors. This causes the TwoPhaseAnnotation processor to go ahead and start its generate phase instead of stopping processing. As a side effect of this behavior the checker is also invoked during the generate phase and issues duplicate error messages to the ones it issued from the check phase.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (BEEHIVE-1010) AptControlInterface does not detect errors from a custom control checker
Posted by "Chad Schoettger (JIRA)" <de...@beehive.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-1010?page=all ]
Chad Schoettger updated BEEHIVE-1010:
-------------------------------------
Attachment: BEEHIVE-1010.patch
beehive-1010.zip
Attached patch for this issue and BEEHIVE-966 (I18N).
For this issue it was necessary to change the ControlChecker interface. Specifically the check method was modified to return a 'boolean' instead of void value. If the checker returns true processing continues, if the checker returns false processing will not continue.
Will post this new behavior to the dev list to make sure no one has any issues with it.
Patch instructions:
Apply the BEEHIVE-1010.patch file.
Add the two new strings.properties files contained in the BEEHIVE-1010.zip file.
> AptControlInterface does not detect errors from a custom control checker
> ------------------------------------------------------------------------
>
> Key: BEEHIVE-1010
> URL: http://issues.apache.org/jira/browse/BEEHIVE-1010
> Project: Beehive
> Type: Bug
> Components: Controls
> Versions: V1
> Reporter: Chad Schoettger
> Assignee: Chad Schoettger
> Attachments: BEEHIVE-1010.patch, beehive-1010.zip
>
> The AptControlInterface class has no way to determine if a custom checker has found errors. This causes the TwoPhaseAnnotation processor to go ahead and start its generate phase instead of stopping processing. As a side effect of this behavior the checker is also invoked during the generate phase and issues duplicate error messages to the ones it issued from the check phase.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira