[GitHub] wu-sheng opened a new pull request #1964: Mysql style storage implementation

[GitBox <gi...@apache.org>]

wu-sheng opened a new pull request #1964: Mysql style storage implementation
URL: https://github.com/apache/incubator-skywalking/pull/1964
 
 
   Hi everyone,
   
   I just finish the codebase of MySQL style storage implementation based on existed H2 implementation. Do following adjustments
   1. SQL syntax follows MySQL protocol
   1. Add missed DAO implementations in H2.
   1. Add indexes for each table.
   
   When in MySQL storage implementation, the settings file is independence from the `application.yml`. You need only set this
   ```yaml
   storage:
     mysql:
   ```
   
   And you have another setting file, named `datasource-setting.properties` with following contents
   ```
   
   jdbcUrl=jdbc:mysql://localhost:3306/swtest
   dataSource.user=root
   dataSource.password=root@1234
   dataSource.cachePrepStmts=true
   dataSource.prepStmtCacheSize=250
   dataSource.prepStmtCacheSqlLimit=2048
   dataSource.useServerPrepStmts=true
   dataSource.useLocalSessionState=true
   dataSource.rewriteBatchedStatements=true
   dataSource.cacheResultSetMetadata=true
   dataSource.cacheServerConfiguration=true
   dataSource.elideSetAutoCommits=true
   dataSource.maintainTimeStats=false
   ```
   
   If anyone wants to implement other SQL based implementation, I suggest following this way too.
   
   The tests haven't been done. I will only ask for merge this at least MySQL tested.
   @candyleer @YunaiV @JaredTan95 You may be interested in this too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services