[GitHub] [beam] zhengbuqian commented on a diff in pull request #23491: Add MultimapState API

[GitBox <gi...@apache.org>]

zhengbuqian commented on code in PR #23491:
URL: https://github.com/apache/beam/pull/23491#discussion_r1011213522


##########
runners/core-java/src/main/java/org/apache/beam/runners/core/InMemoryStateInternals.java:
##########
@@ -463,6 +475,114 @@ public InMemoryBag<T> copy() {
     }
   }
 
+  /** An {@link InMemoryState} implementation of {@link MultimapState}. */
+  public static final class InMemoryMultimap<K, V>
+      implements MultimapState<K, V>, InMemoryState<InMemoryMultimap<K, V>> {
+    private final Coder<K> keyCoder;
+    private final Coder<V> valueCoder;
+    private Multimap<K, V> contents = ArrayListMultimap.create();

Review Comment:
   Ah I didn't think of this before. Then this means beam Map/Multimap will have a different semantic from the java Map: 
   
   * in beam Map/Multimap: 2 keys are considered same key if their encoded byte array is the same.
   * in java Map: 2 keys are considered same key if `key1.equals(key2)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org