You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2026/04/27 14:21:47 UTC
(camel) branch main updated: MQTT: Throw Runtime Exception when manual ack fails (#22117)
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new 1165776e2124 MQTT: Throw Runtime Exception when manual ack fails (#22117)
1165776e2124 is described below
commit 1165776e212401326f1bbacfc7973f269c13917b
Author: nkokitkar <15...@users.noreply.github.com>
AuthorDate: Mon Apr 27 07:21:40 2026 -0700
MQTT: Throw Runtime Exception when manual ack fails (#22117)
* Throw Runtime Exception when manual ack fails
* Resolve Pr comments
* Fix: restore error log level in onFailure callback
Revert the log level in onFailure from debug back to error, as
this callback handles exchange processing failures which should
not be silently swallowed at debug level.
Addresses review comment from @Croway.
Co-authored-by: Copilot <22...@users.noreply.github.com>
---------
Co-authored-by: Copilot <22...@users.noreply.github.com>
---
.../component/paho/mqtt5/PahoMqtt5Consumer.java | 4 +-
.../PahoMqtt5ConsumerManualAckExceptionTest.java | 130 +++++++++++++++++++++
.../apache/camel/component/paho/PahoConsumer.java | 4 +-
.../paho/PahoConsumerManualAckExceptionTest.java | 130 +++++++++++++++++++++
4 files changed, 266 insertions(+), 2 deletions(-)
diff --git a/components/camel-paho-mqtt5/src/main/java/org/apache/camel/component/paho/mqtt5/PahoMqtt5Consumer.java b/components/camel-paho-mqtt5/src/main/java/org/apache/camel/component/paho/mqtt5/PahoMqtt5Consumer.java
index c129ccba1780..ef6413031742 100644
--- a/components/camel-paho-mqtt5/src/main/java/org/apache/camel/component/paho/mqtt5/PahoMqtt5Consumer.java
+++ b/components/camel-paho-mqtt5/src/main/java/org/apache/camel/component/paho/mqtt5/PahoMqtt5Consumer.java
@@ -167,7 +167,9 @@ public class PahoMqtt5Consumer extends DefaultConsumer {
try {
PahoMqtt5Consumer.this.client.messageArrivedComplete(mqttMessage.getId(), mqttMessage.getQos());
} catch (MqttException e) {
- LOG.warn("Failed to commit message with ID: {} due to {}", mqttMessage.getId(), e.getMessage(), e);
+ getExceptionHandler().handleException(
+ "Error acknowledging MQTT message with ID: " + mqttMessage.getId(),
+ exchange, e);
}
}
diff --git a/components/camel-paho-mqtt5/src/test/java/org/apache/camel/component/paho/mqtt5/PahoMqtt5ConsumerManualAckExceptionTest.java b/components/camel-paho-mqtt5/src/test/java/org/apache/camel/component/paho/mqtt5/PahoMqtt5ConsumerManualAckExceptionTest.java
new file mode 100644
index 000000000000..d791979998ca
--- /dev/null
+++ b/components/camel-paho-mqtt5/src/test/java/org/apache/camel/component/paho/mqtt5/PahoMqtt5ConsumerManualAckExceptionTest.java
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.paho.mqtt5;
+
+import java.util.List;
+
+import org.apache.camel.Exchange;
+import org.apache.camel.Processor;
+import org.apache.camel.spi.ExceptionHandler;
+import org.apache.camel.spi.Synchronization;
+import org.apache.camel.test.junit6.CamelTestSupport;
+import org.eclipse.paho.mqttv5.client.MqttClient;
+import org.eclipse.paho.mqttv5.common.MqttException;
+import org.eclipse.paho.mqttv5.common.MqttMessage;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.contains;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.doThrow;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.verifyNoInteractions;
+
+public class PahoMqtt5ConsumerManualAckExceptionTest extends CamelTestSupport {
+
+ @Test
+ public void testOnCompleteCallsExceptionHandlerOnMqttException() throws Exception {
+ PahoMqtt5Endpoint endpoint = context.getEndpoint(
+ "paho-mqtt5:test?manualAcksEnabled=true&brokerUrl=tcp://localhost:1883", PahoMqtt5Endpoint.class);
+
+ Processor mockProcessor = mock(Processor.class);
+ PahoMqtt5Consumer consumer = new PahoMqtt5Consumer(endpoint, mockProcessor);
+
+ MqttClient mockClient = mock(MqttClient.class);
+ doThrow(new MqttException(MqttException.REASON_CODE_CLIENT_EXCEPTION))
+ .when(mockClient).messageArrivedComplete(any(int.class), any(int.class));
+ consumer.setClient(mockClient);
+
+ ExceptionHandler mockExceptionHandler = mock(ExceptionHandler.class);
+ consumer.setExceptionHandler(mockExceptionHandler);
+
+ MqttMessage mqttMessage = new MqttMessage("test".getBytes());
+ mqttMessage.setQos(2);
+
+ Exchange exchange = consumer.createExchange(mqttMessage, "test-topic");
+ List<Synchronization> completions = exchange.getExchangeExtension().handoverCompletions();
+
+ assertNotNull(completions);
+ assertFalse(completions.isEmpty());
+
+ // Trigger the onComplete callback (simulating successful exchange processing)
+ completions.get(0).onComplete(exchange);
+
+ // Verify exception handler was called instead of throwing RuntimeException
+ verify(mockExceptionHandler).handleException(
+ contains("Error acknowledging MQTT message"),
+ eq(exchange),
+ any(MqttException.class));
+ }
+
+ @Test
+ public void testOnCompleteAcknowledgesSuccessfully() throws Exception {
+ PahoMqtt5Endpoint endpoint = context.getEndpoint(
+ "paho-mqtt5:test?manualAcksEnabled=true&brokerUrl=tcp://localhost:1883", PahoMqtt5Endpoint.class);
+
+ Processor mockProcessor = mock(Processor.class);
+ PahoMqtt5Consumer consumer = new PahoMqtt5Consumer(endpoint, mockProcessor);
+
+ MqttClient mockClient = mock(MqttClient.class);
+ consumer.setClient(mockClient);
+
+ ExceptionHandler mockExceptionHandler = mock(ExceptionHandler.class);
+ consumer.setExceptionHandler(mockExceptionHandler);
+
+ MqttMessage mqttMessage = new MqttMessage("test".getBytes());
+ mqttMessage.setQos(2);
+
+ Exchange exchange = consumer.createExchange(mqttMessage, "test-topic");
+ List<Synchronization> completions = exchange.getExchangeExtension().handoverCompletions();
+
+ assertNotNull(completions);
+ assertEquals(1, completions.size());
+
+ // Trigger the onComplete callback
+ completions.get(0).onComplete(exchange);
+
+ // Verify messageArrivedComplete was called and no exception was handled
+ verify(mockClient).messageArrivedComplete(mqttMessage.getId(), mqttMessage.getQos());
+ verifyNoInteractions(mockExceptionHandler);
+ }
+
+ @Test
+ public void testNoCompletionRegisteredWhenManualAcksDisabled() throws Exception {
+ PahoMqtt5Endpoint endpoint = context.getEndpoint(
+ "paho-mqtt5:test?brokerUrl=tcp://localhost:1883", PahoMqtt5Endpoint.class);
+
+ Processor mockProcessor = mock(Processor.class);
+ PahoMqtt5Consumer consumer = new PahoMqtt5Consumer(endpoint, mockProcessor);
+
+ MqttClient mockClient = mock(MqttClient.class);
+ consumer.setClient(mockClient);
+
+ MqttMessage mqttMessage = new MqttMessage("test".getBytes());
+
+ Exchange exchange = consumer.createExchange(mqttMessage, "test-topic");
+ List<Synchronization> completions = exchange.getExchangeExtension().handoverCompletions();
+
+ // No synchronization should be registered when manualAcks is disabled
+ assertTrue(completions == null || completions.isEmpty());
+ }
+}
diff --git a/components/camel-paho/src/main/java/org/apache/camel/component/paho/PahoConsumer.java b/components/camel-paho/src/main/java/org/apache/camel/component/paho/PahoConsumer.java
index b2544c42e255..2cfcfe1c526b 100644
--- a/components/camel-paho/src/main/java/org/apache/camel/component/paho/PahoConsumer.java
+++ b/components/camel-paho/src/main/java/org/apache/camel/component/paho/PahoConsumer.java
@@ -154,7 +154,9 @@ public class PahoConsumer extends DefaultConsumer {
try {
PahoConsumer.this.client.messageArrivedComplete(mqttMessage.getId(), mqttMessage.getQos());
} catch (MqttException e) {
- LOG.warn("Failed to commit message with ID {} due to MqttException.", mqttMessage.getId());
+ getExceptionHandler().handleException(
+ "Error acknowledging MQTT message with ID: " + mqttMessage.getId(),
+ exchange, e);
}
}
diff --git a/components/camel-paho/src/test/java/org/apache/camel/component/paho/PahoConsumerManualAckExceptionTest.java b/components/camel-paho/src/test/java/org/apache/camel/component/paho/PahoConsumerManualAckExceptionTest.java
new file mode 100644
index 000000000000..82accbb4c7f0
--- /dev/null
+++ b/components/camel-paho/src/test/java/org/apache/camel/component/paho/PahoConsumerManualAckExceptionTest.java
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.paho;
+
+import java.util.List;
+
+import org.apache.camel.Exchange;
+import org.apache.camel.Processor;
+import org.apache.camel.spi.ExceptionHandler;
+import org.apache.camel.spi.Synchronization;
+import org.apache.camel.test.junit6.CamelTestSupport;
+import org.eclipse.paho.client.mqttv3.MqttClient;
+import org.eclipse.paho.client.mqttv3.MqttException;
+import org.eclipse.paho.client.mqttv3.MqttMessage;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.contains;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.doThrow;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.verifyNoInteractions;
+
+public class PahoConsumerManualAckExceptionTest extends CamelTestSupport {
+
+ @Test
+ public void testOnCompleteCallsExceptionHandlerOnMqttException() throws Exception {
+ PahoEndpoint endpoint = context.getEndpoint(
+ "paho:test?manualAcksEnabled=true&brokerUrl=tcp://localhost:1883", PahoEndpoint.class);
+
+ Processor mockProcessor = mock(Processor.class);
+ PahoConsumer consumer = new PahoConsumer(endpoint, mockProcessor);
+
+ MqttClient mockClient = mock(MqttClient.class);
+ doThrow(new MqttException(MqttException.REASON_CODE_CLIENT_EXCEPTION))
+ .when(mockClient).messageArrivedComplete(any(int.class), any(int.class));
+ consumer.setClient(mockClient);
+
+ ExceptionHandler mockExceptionHandler = mock(ExceptionHandler.class);
+ consumer.setExceptionHandler(mockExceptionHandler);
+
+ MqttMessage mqttMessage = new MqttMessage("test".getBytes());
+ mqttMessage.setQos(2);
+
+ Exchange exchange = consumer.createExchange(mqttMessage, "test-topic");
+ List<Synchronization> completions = exchange.getExchangeExtension().handoverCompletions();
+
+ assertNotNull(completions);
+ assertFalse(completions.isEmpty());
+
+ // Trigger the onComplete callback (simulating successful exchange processing)
+ completions.get(0).onComplete(exchange);
+
+ // Verify exception handler was called instead of throwing RuntimeException
+ verify(mockExceptionHandler).handleException(
+ contains("Error acknowledging MQTT message"),
+ eq(exchange),
+ any(MqttException.class));
+ }
+
+ @Test
+ public void testOnCompleteAcknowledgesSuccessfully() throws Exception {
+ PahoEndpoint endpoint = context.getEndpoint(
+ "paho:test?manualAcksEnabled=true&brokerUrl=tcp://localhost:1883", PahoEndpoint.class);
+
+ Processor mockProcessor = mock(Processor.class);
+ PahoConsumer consumer = new PahoConsumer(endpoint, mockProcessor);
+
+ MqttClient mockClient = mock(MqttClient.class);
+ consumer.setClient(mockClient);
+
+ ExceptionHandler mockExceptionHandler = mock(ExceptionHandler.class);
+ consumer.setExceptionHandler(mockExceptionHandler);
+
+ MqttMessage mqttMessage = new MqttMessage("test".getBytes());
+ mqttMessage.setQos(2);
+
+ Exchange exchange = consumer.createExchange(mqttMessage, "test-topic");
+ List<Synchronization> completions = exchange.getExchangeExtension().handoverCompletions();
+
+ assertNotNull(completions);
+ assertEquals(1, completions.size());
+
+ // Trigger the onComplete callback
+ completions.get(0).onComplete(exchange);
+
+ // Verify messageArrivedComplete was called and no exception was handled
+ verify(mockClient).messageArrivedComplete(mqttMessage.getId(), mqttMessage.getQos());
+ verifyNoInteractions(mockExceptionHandler);
+ }
+
+ @Test
+ public void testNoCompletionRegisteredWhenManualAcksDisabled() throws Exception {
+ PahoEndpoint endpoint = context.getEndpoint(
+ "paho:test?brokerUrl=tcp://localhost:1883", PahoEndpoint.class);
+
+ Processor mockProcessor = mock(Processor.class);
+ PahoConsumer consumer = new PahoConsumer(endpoint, mockProcessor);
+
+ MqttClient mockClient = mock(MqttClient.class);
+ consumer.setClient(mockClient);
+
+ MqttMessage mqttMessage = new MqttMessage("test".getBytes());
+
+ Exchange exchange = consumer.createExchange(mqttMessage, "test-topic");
+ List<Synchronization> completions = exchange.getExchangeExtension().handoverCompletions();
+
+ // No synchronization should be registered when manualAcks is disabled
+ assertTrue(completions == null || completions.isEmpty());
+ }
+}