[GitHub] [superset] eschutho commented on a diff in pull request #19855: feat(explore): Frontend implementation of dataset creation from infobox

[GitBox <gi...@apache.org>]

eschutho commented on code in PR #19855:
URL: https://github.com/apache/superset/pull/19855#discussion_r860242462


##########
superset-frontend/packages/superset-ui-chart-controls/src/types.ts:
##########
@@ -65,6 +65,11 @@ export interface DatasourceMeta {
   granularity_sqla?: string;
   datasource_name: string | null;
   description: string | null;
+  sl_dataset?: {
+    sl_table?: any;

Review Comment:
   I think these values would actually be string options of `type`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org