You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/05 10:54:34 UTC

[GitHub] [kafka] dengziming opened a new pull request #10068: MINOR: MINOR: StopReplicaResp and StopReplicaReq Test should cover all available version

dengziming opened a new pull request #10068:
URL: https://github.com/apache/kafka/pull/10068


   *More detailed description of your change*
   The test case in `StopReplicaRespTest` and `StopReplicaReq` didn't cover all versions.
   
   *Summary of testing strategy (including rationale)*
   QA
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 merged pull request #10068: MINOR: StopReplicaResp and StopReplicaReq Test should cover all available version

Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #10068:
URL: https://github.com/apache/kafka/pull/10068


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #10068: MINOR: StopReplicaResp and StopReplicaReq Test should cover all available version

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #10068:
URL: https://github.com/apache/kafka/pull/10068#issuecomment-774601620


   Failures seem unrelated to this pr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dajac commented on pull request #10068: MINOR: StopReplicaResp and StopReplicaReq Test should cover all available version

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #10068:
URL: https://github.com/apache/kafka/pull/10068#issuecomment-774140916


   I've re-triggered Jenkins. I will merge once we have a clean run.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #10068: MINOR: StopReplicaResp and StopReplicaReq Test should cover all available version

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #10068:
URL: https://github.com/apache/kafka/pull/10068#issuecomment-774708473


   @dengziming Nice patch!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org