You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/23 16:46:41 UTC

[GitHub] [airflow] jmcarp commented on a change in pull request #12539: Use html urls instead of onclick for dags view links.

jmcarp commented on a change in pull request #12539:
URL: https://github.com/apache/airflow/pull/12539#discussion_r528847876



##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -421,10 +425,6 @@ <h2>DAGs</h2>
           if (d.count > 0)
               return"cursor:pointer;"
         })
-        .on('click', function(d, i) {
-          if (d.count > 0)

Review comment:
       I'm also not sure why we had this conditional. I'd be happy to restore it if you think it's useful.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org