You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/29 09:43:51 UTC

[GitHub] [shardingsphere] Liangda-w commented on a change in pull request #10514: Proofread Oracle SQL - SET TRANSACTION

Liangda-w commented on a change in pull request #10514:
URL: https://github.com/apache/shardingsphere/pull/10514#discussion_r641916946



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/TCLStatement.g4
##########
@@ -20,7 +20,10 @@ grammar TCLStatement;
 import Symbol, Keyword, OracleKeyword, Literals, BaseRule;
 
 setTransaction
-    : SET TRANSACTION
+    : SET TRANSACTION ((READ (ONLY | WRITE)

Review comment:
       Hi @wgy8283335, could you please specify which point and why it's not correct? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org