You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/11/01 21:50:00 UTC
[jira] [Commented] (HDFS-16827) [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider
[ https://issues.apache.org/jira/browse/HDFS-16827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627347#comment-17627347 ]
ASF GitHub Bot commented on HDFS-16827:
---------------------------------------
simbadzina commented on code in PR #5088:
URL: https://github.com/apache/hadoop/pull/5088#discussion_r1010933954
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java:
##########
@@ -2879,9 +2881,12 @@ private void processRpcRequest(RpcRequestHeaderProto header,
stateId = alignmentContext.receiveRequestState(
header, getMaxIdleTime());
call.setClientStateId(stateId);
- if (header.hasRouterFederatedState()) {
- call.setFederatedNamespaceState(header.getRouterFederatedState());
- }
+ }
+ if (header.hasRouterFederatedState()) {
+ call.setFederatedNamespaceState(header.getRouterFederatedState());
+ } else if (header.hasStateId()) {
+ // Only used to determine whether to return federatedNamespaceState.
+ call.setFederatedNamespaceState(EMPTY_BYTE_STRING);
Review Comment:
Can you expand on why we need this else part?
> [RBF SBN] RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-16827
> URL: https://issues.apache.org/jira/browse/HDFS-16827
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Major
> Labels: pull-request-available
>
> RouterStateIdContext shouldn't update the ResponseState if client doesn't use ObserverReadProxyProvider.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org