[GitHub] [incubator-iceberg] rdblue commented on issue #247: Fixes `withPartitionPath` API for transform functions that consider `toHumanString` path representations incompatible as type and value with the partition value preserved in the spec

[GitBox <gi...@apache.org>]

rdblue commented on issue #247: Fixes `withPartitionPath` API for transform functions that consider `toHumanString` path representations incompatible as type and value with the partition value preserved in the spec
URL: https://github.com/apache/incubator-iceberg/pull/247#issuecomment-508165479
 
 
   I'm not sure that we want to do this. The output of `toHumanString` should never be parsed. `withPartitionPath` is only intended to be used when adding files from Hive tables during conversion. In fact, we should probably separate it out into some sort of Hive util method in `iceberg-hive`.
   
   Is there a use case for parsing Iceberg paths? I would assume not because Iceberg keeps partition values in metadata to avoid the need to ever parse them from a path.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org