You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by sigram <gi...@git.apache.org> on 2016/11/29 13:59:32 UTC
[GitHub] lucene-solr pull request #120: SOLR-4735 Improve Solr metrics reporting
GitHub user sigram opened a pull request:
https://github.com/apache/lucene-solr/pull/120
SOLR-4735 Improve Solr metrics reporting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sigram/lucene-solr jira/solr-4735
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
----
commit dba0663c79f7b27d4626152d36f8d6d4c62a878d
Author: Andrzej Bialecki <an...@lucidworks.com>
Date: 2016-11-23T12:48:26Z
Initial patch from Jira.
commit 1ade9c443dbd5b9eae2ec5208b233d28fb20a8cb
Author: Andrzej Bialecki <an...@lucidworks.com>
Date: 2016-11-24T10:45:20Z
Merge branch 'master' into jira/solr-4735
commit ba2a94fb52d21ed05053a098c8fb9919a469e5b3
Author: Andrzej Bialecki <an...@lucidworks.com>
Date: 2016-11-24T15:32:04Z
Use SharedMetricRegistries for managing per-core metrics.
commit 7199e818da503bc0e8a40fed7d6a1f742ecbae55
Author: Andrzej Bialecki <an...@lucidworks.com>
Date: 2016-11-24T15:44:55Z
Revert accidental changes to this file.
commit a4514638df8a2528f339107869b03fe568856fd9
Author: Andrzej Bialecki <an...@lucidworks.com>
Date: 2016-11-28T14:01:42Z
SOLR-4735 Use separate registries for core and other stuff. Use collapsible and
configurable namespace.
commit bf424d1ec1602dffeb33ab0acc8f470e351a6959
Author: Kevin Risden <kr...@apache.org>
Date: 2016-11-22T19:22:16Z
SOLR-9728: Ability to specify Key Store type in solr.in file for SSL
commit 5b2594350df11ef54d52f417b34c6d082ad85e89
Author: Noble Paul <no...@apache.org>
Date: 2016-11-29T02:35:47Z
SOLR-9784: added deprecation javadocs
commit 32c4bd7cc0ac2e93e833f5fe84be4ff69f0b7aeb
Author: Noble Paul <no...@apache.org>
Date: 2016-11-29T02:36:26Z
Merge remote-tracking branch 'origin/master'
commit 9b4f99c1b351b1401e2dd5922a06d79a809332fb
Author: Andrzej Bialecki <an...@lucidworks.com>
Date: 2016-11-29T10:37:14Z
SOLR-4735 Reorder args from top level to bottom.
commit 70b358960dfe8a6da35991b2a84c93cc9370c3d8
Author: Noble Paul <no...@apache.org>
Date: 2016-11-29T12:32:59Z
SOLR-9546: remove unnecessary boxing
commit 2af8ec2689610f4dfb1f5d87b069b0eb54f72155
Author: Andrzej Bialecki <an...@lucidworks.com>
Date: 2016-11-29T13:48:44Z
SOLR-4735 More cleanup and generalization of JMX reporter.
commit 4b7002eae75839d2f56a17a65d7e789cb71a9b26
Author: Andrzej Bialecki <an...@lucidworks.com>
Date: 2016-11-29T13:56:24Z
Merge branch 'master' into jira/solr-4735
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request: Fixed a typo in various solrconfig.xml f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucene-solr/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #120: SOLR-4735 Improve Solr metrics reporting
Posted by randomstatistic <gi...@git.apache.org>.
Github user randomstatistic commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/120#discussion_r90144072
--- Diff: solr/core/src/java/org/apache/solr/metrics/SolrMetricManager.java ---
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.metrics;
+
+import java.util.Set;
+
+import com.codahale.metrics.Counter;
+import com.codahale.metrics.Histogram;
+import com.codahale.metrics.Meter;
+import com.codahale.metrics.MetricFilter;
+import com.codahale.metrics.MetricRegistry;
+import com.codahale.metrics.SharedMetricRegistries;
+import com.codahale.metrics.Snapshot;
+import com.codahale.metrics.Timer;
+import org.apache.solr.common.util.NamedList;
+
+/**
+ *
+ */
+public class SolrMetricManager {
+
+ public static final String REGISTRY_NAME_PREFIX = "solr";
+ public static final String DEFAULT_REGISTRY = MetricRegistry.name(REGISTRY_NAME_PREFIX, "default");
+
+ // don't create instances of this class
+ private SolrMetricManager() { }
+
+
+ /**
+ * Return a set of existing registry names.
+ */
+ public static Set<String> registryNames() {
+ return SharedMetricRegistries.names();
+ }
+
+ /**
+ * Get (or create if not present) a named registry
+ * @param registry name of the registry
+ * @return existing or newly created registry
+ */
+ public static MetricRegistry registryFor(String registry) {
+ return SharedMetricRegistries.getOrCreate(overridableRegistryName(registry));
+ }
+
+ /**
+ * Remove all metrics from a specified registry.
+ * @param registry registry name
+ */
+ public static void clearRegistryFor(String registry) {
+ SharedMetricRegistries.getOrCreate(overridableRegistryName(registry)).removeMatching(MetricFilter.ALL);
--- End diff --
This, and several other places below could delegate to `registryFor(registry)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org