You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by zj...@apache.org on 2019/07/11 02:08:43 UTC

[zeppelin] branch master updated: [ZEPPELIN-4224]. commons-exec is missing in zeppelin-interpreter-parent

This is an automated email from the ASF dual-hosted git repository.

zjffdu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new 0878ae7  [ZEPPELIN-4224]. commons-exec is missing in zeppelin-interpreter-parent
0878ae7 is described below

commit 0878ae70bd6a576802b8e02d7b988dbbcf93fc6b
Author: Jeff Zhang <zj...@apache.org>
AuthorDate: Fri Jul 5 13:30:15 2019 +0800

    [ZEPPELIN-4224]. commons-exec is missing in zeppelin-interpreter-parent
    
    ### What is this PR for?
    
    commons-exec is excluded in zeppelin-interpeter-api which is the shaded zeppelin-interpreter. So we should add common-exec explicitly in zeppelin-interpreter-parent so that all interpreter can use it and include it their packaged jar.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://jira.apache.org/jira/browse/ZEPPELIN-4224
    
    ### How should this be tested?
    * CI pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Jeff Zhang <zj...@apache.org>
    
    Closes #3399 from zjffdu/ZEPPELIN-4224 and squashes the following commits:
    
    b0eb0d51d [Jeff Zhang] [ZEPPELIN-4224]. commons-exec is missing in zeppelin-interpreter-parent
---
 pom.xml                             | 7 +++++++
 zeppelin-interpreter-parent/pom.xml | 5 +++++
 zeppelin-interpreter/pom.xml        | 2 --
 3 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 17774c0..2854b16 100644
--- a/pom.xml
+++ b/pom.xml
@@ -117,6 +117,7 @@
     <httpcomponents.asyncclient.version>4.0.2</httpcomponents.asyncclient.version>
     <commons.lang.version>2.5</commons.lang.version>
     <commons.configuration.version>1.9</commons.configuration.version>
+    <commons.exec.version>1.3</commons.exec.version>
     <commons.codec.version>1.5</commons.codec.version>
     <commons.io.version>2.4</commons.io.version>
     <commons.collections.version>3.2.2</commons.collections.version>
@@ -210,6 +211,12 @@
       </dependency>
 
       <dependency>
+        <groupId>org.apache.commons</groupId>
+        <artifactId>commons-exec</artifactId>
+        <version>${commons.exec.version}</version>
+      </dependency>
+
+      <dependency>
         <groupId>com.google.code.gson</groupId>
         <artifactId>gson</artifactId>
         <version>${gson.version}</version>
diff --git a/zeppelin-interpreter-parent/pom.xml b/zeppelin-interpreter-parent/pom.xml
index 74d091e..8f3e5ec 100644
--- a/zeppelin-interpreter-parent/pom.xml
+++ b/zeppelin-interpreter-parent/pom.xml
@@ -63,6 +63,11 @@
     </dependency>
 
     <dependency>
+      <groupId>org.apache.commons</groupId>
+      <artifactId>commons-exec</artifactId>
+    </dependency>
+    
+    <dependency>
       <groupId>log4j</groupId>
       <artifactId>log4j</artifactId>
     </dependency>
diff --git a/zeppelin-interpreter/pom.xml b/zeppelin-interpreter/pom.xml
index 0a6d92d..085a4f5 100644
--- a/zeppelin-interpreter/pom.xml
+++ b/zeppelin-interpreter/pom.xml
@@ -38,7 +38,6 @@
   <properties>
     <!--library versions-->
     <commons.pool2.version>2.3</commons.pool2.version>
-    <commons.exec.version>1.3</commons.exec.version>
     <maven.plugin.api.version>3.0</maven.plugin.api.version>
     <aether.version>1.12</aether.version>
     <maven.aeither.provider.version>3.0.3</maven.aeither.provider.version>
@@ -116,7 +115,6 @@
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-exec</artifactId>
-      <version>${commons.exec.version}</version>
     </dependency>
 
     <dependency>