[GitHub] [inlong] pocozh commented on a diff in pull request #5883: [INLONG-5874][Agent] Add msgTime attribute in PackProxyMessage

[GitBox <gi...@apache.org>]

pocozh commented on code in PR #5883:
URL: https://github.com/apache/inlong/pull/5883#discussion_r970248614


##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sinks/ProxySink.java:
##########
@@ -104,11 +103,10 @@ public void write(Message message) {
                                 }
                                 // add message to package proxy
                                 packProxyMessage.addProxyMessage(proxyMessage);
-                                //
+                                // update msgTime
+                                packProxyMessage.updateMsgTime(System.currentTimeMillis());

Review Comment:
   > It is better to use current time in Agent source.
   
   In `agent-source`, messages are encapsulated piece by piece. But, they are packaged to be sent to `dataproxy` with only one  `msgTime`. So, is it better to use current time here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org