You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Aleksey Yeschenko (JIRA)" <ji...@apache.org> on 2014/05/04 01:56:15 UTC

[jira] [Comment Edited] (CASSANDRA-7107) General minor tidying of CollationController path

    [ https://issues.apache.org/jira/browse/CASSANDRA-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988856#comment-13988856 ] 

Aleksey Yeschenko edited comment on CASSANDRA-7107 at 5/3/14 11:55 PM:
-----------------------------------------------------------------------

Slightly worried about a potentiall off by one at https://github.com/iamaleksey/cassandra/blob/7107/src/java/org/apache/cassandra/db/ArrayBackedSortedColumns.java#L526, but the more I stare at it, the more benign it looks to me. Wouldn't mind a second look by a third person at this particular code just to help me sleep better.


was (Author: iamaleksey):
Slightly worried about a potentiall off by one at https://github.com/iamaleksey/cassandra/blob/7107/src/java/org/apache/cassandra/db/ArrayBackedSortedColumns.java#L526, but the more I start at it, the more benign it looks to me. Wouldn't mind a second look by a third person at this particular code just to help me sleep better.

> General minor tidying of CollationController path
> -------------------------------------------------
>
>                 Key: CASSANDRA-7107
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7107
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>             Fix For: 2.1 rc1
>
>
> There is a lot of unnecessary boiler plate when grabbing an iterator from an in-memory column family. This patch:
> * Removes FakeCellName
> * Avoids wrapping a non-OnDiskAtomIterator as an OnDiskAtomIterator except when the wrapping is useful
> * Removes ColumnSlice.NavigableSetIterator and creates a simpler more direct equivalent in ABTC
> * Does not construct a SliceIterator in either ABSC or ABTC if only one slice is requested (just returns that slice as an Iterator)
> * Does not construct multiple list indirections in ABSC when constructing a slice
> * Shares forward/reverse iterators in ABSC between slices and full-iteration
> * Avoids O(N) comparisons during collation of results into an ABSC, by using the knowledge that all columns are provided in insertion order from a merge iterator



--
This message was sent by Atlassian JIRA
(v6.2#6252)