You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by somideshmukh <gi...@git.apache.org> on 2015/11/16 11:22:16 UTC
[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...
GitHub user somideshmukh opened a pull request:
https://github.com/apache/spark/pull/9733
[SPARK-10946][SQL]JDBC - Use Statement.executeUpdate instead of PreparedStatement.executeUpdate for DDLs
New changes with JDBCRDD
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/somideshmukh/spark SomilBranch-1.1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9733.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9733
----
commit 9db069df8410537a9ce5526b2e04a4e3c6e2bea4
Author: somideshmukh <so...@us.ibm.com>
Date: 2015-11-16T10:03:05Z
[SPARK-10946][SQL]JDBC - Use Statement.executeUpdate instead of PreparedStatement.executeUpdate for DDLs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9733#issuecomment-156981802
I agree with this, and am OK to merge this.
There is still an issue with not closing the `Statement`s, although it's a separate issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9733#issuecomment-157010778
**[Test build #2063 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2063/consoleFull)** for PR 9733 at commit [`9db069d`](https://github.com/apache/spark/commit/9db069df8410537a9ce5526b2e04a4e3c6e2bea4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9733#issuecomment-156981862
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10946][SQL]JDBC - Use Statement.execute...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9733#issuecomment-156982691
**[Test build #2063 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2063/consoleFull)** for PR 9733 at commit [`9db069d`](https://github.com/apache/spark/commit/9db069df8410537a9ce5526b2e04a4e3c6e2bea4).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org