You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by grkvlt <gi...@git.apache.org> on 2014/10/07 16:24:42 UTC
[GitHub] incubator-brooklyn pull request: Trim brooklyn.properties values o...
GitHub user grkvlt opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/223
Trim brooklyn.properties values on import
The `brooklyn.properties` file should have its property values trimmed of whitespace at the start and end, to prevent issues with spaces in un-quoted passwords or credentials being added.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/grkvlt/incubator-brooklyn fix/trim-brooklyn-properties
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/223.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #223
----
commit 2a0cc9a75e3915e6be30033e10e444ad16a9d50c
Author: Andrew Kennedy <gr...@apache.org>
Date: 2014-10-07T13:06:34Z
Trim brooklyn.properties values of whitespace when loading
commit 7d0564033832205d34e73673de7e13149120f89b
Author: Andrew Kennedy <gr...@apache.org>
Date: 2014-10-07T13:07:01Z
Fix tabs in formatting
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Trim brooklyn.properties values o...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/223#issuecomment-58289642
what if someone needs to include whitespace? this needs discussion i think. @aledsage wdyt?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Trim brooklyn.properties values o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---