You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2016/03/19 20:59:40 UTC
Review Request 45076: Improve presentation and organization of the
scheduler landing page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45076/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Bill Farner.
Repository: aurora
Description
-------
I have opted for a very simple, incremental improvement here.
Diffs
-----
src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979
Diff: https://reviews.apache.org/r/45076/diff/
Testing
-------
Thanks,
Stephan Erb
Re: Review Request 45076: Improve presentation and organization of the
scheduler landing page
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45076/#review124420
-----------------------------------------------------------
@ReviewBot retry
- Stephan Erb
On March 19, 2016, 9 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45076/
> -----------------------------------------------------------
>
> (Updated March 19, 2016, 9 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I have opted for a very simple, incremental improvement here.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979
>
> Diff: https://reviews.apache.org/r/45076/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> aurora-landing-page.png
> https://reviews.apache.org/media/uploaded/files/2016/03/19/9a809739-966a-49e3-bf69-df03754be1c8__aurora-landing-page.png
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 45076: Improve presentation and organization of the
scheduler landing page
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45076/#review124477
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On March 19, 2016, 8 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45076/
> -----------------------------------------------------------
>
> (Updated March 19, 2016, 8 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I have opted for a very simple, incremental improvement here.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979
>
> Diff: https://reviews.apache.org/r/45076/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> aurora-landing-page.png
> https://reviews.apache.org/media/uploaded/files/2016/03/19/9a809739-966a-49e3-bf69-df03754be1c8__aurora-landing-page.png
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 45076: Improve presentation and organization of the
scheduler landing page
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45076/#review124418
-----------------------------------------------------------
Master (b24619b) is red with this patch.
./build-support/jenkins/build.sh
CAP#1 extends Unit<CAP#1> from capture of ?
/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java:44: error: incompatible types: cannot infer type-variable(s) E,F,T
return ImmutableList.copyOf(Iterables.transform(Parsers.MULTI_VALUE_SPLITTER.split(raw),
^
(argument mismatch; Iterable<CAP#1> cannot be converted to Iterable<? extends CAP#1>)
where E,F,T are type-variables:
E extends Object declared in method <E>copyOf(Iterable<? extends E>)
F extends Object declared in method <F,T>transform(Iterable<F>,Function<? super F,? extends T>)
T extends Object declared in method <F,T>transform(Iterable<F>,Function<? super F,? extends T>)
where CAP#1 is a fresh type-variable:
CAP#1 extends Object from capture of ?
/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java:46: error: incompatible types: cannot infer type-variable(s) E,F,T
return ImmutableSet.copyOf(Iterables.transform(Parsers.MULTI_VALUE_SPLITTER.split(raw),
^
(argument mismatch; Iterable<CAP#1> cannot be converted to Iterable<? extends CAP#1>)
where E,F,T are type-variables:
E extends Object declared in method <E>copyOf(Iterable<? extends E>)
F extends Object declared in method <F,T>transform(Iterable<F>,Function<? super F,? extends T>)
T extends Object declared in method <F,T>transform(Iterable<F>,Function<? super F,? extends T>)
where CAP#1 is a fresh type-variable:
CAP#1 extends Object from capture of ?
Note: /home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/main/java/org/apache/aurora/common/testing/easymock/EasyMockTest.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
8 errors
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':commons:compileJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 7 mins 17.902 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 19, 2016, 8 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45076/
> -----------------------------------------------------------
>
> (Updated March 19, 2016, 8 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I have opted for a very simple, incremental improvement here.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979
>
> Diff: https://reviews.apache.org/r/45076/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> aurora-landing-page.png
> https://reviews.apache.org/media/uploaded/files/2016/03/19/9a809739-966a-49e3-bf69-df03754be1c8__aurora-landing-page.png
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 45076: Improve presentation and organization of the
scheduler landing page
Posted by Bill Farner <wf...@apache.org>.
> On March 19, 2016, 1:44 p.m., Aurora ReviewBot wrote:
> > Master (b24619b) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > CAP#1 extends Unit<CAP#1> from capture of ?
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java:44: error: incompatible types: cannot infer type-variable(s) E,F,T
> > return ImmutableList.copyOf(Iterables.transform(Parsers.MULTI_VALUE_SPLITTER.split(raw),
> > ^
> > (argument mismatch; Iterable<CAP#1> cannot be converted to Iterable<? extends CAP#1>)
> > where E,F,T are type-variables:
> > E extends Object declared in method <E>copyOf(Iterable<? extends E>)
> > F extends Object declared in method <F,T>transform(Iterable<F>,Function<? super F,? extends T>)
> > T extends Object declared in method <F,T>transform(Iterable<F>,Function<? super F,? extends T>)
> > where CAP#1 is a fresh type-variable:
> > CAP#1 extends Object from capture of ?
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java:46: error: incompatible types: cannot infer type-variable(s) E,F,T
> > return ImmutableSet.copyOf(Iterables.transform(Parsers.MULTI_VALUE_SPLITTER.split(raw),
> > ^
> > (argument mismatch; Iterable<CAP#1> cannot be converted to Iterable<? extends CAP#1>)
> > where E,F,T are type-variables:
> > E extends Object declared in method <E>copyOf(Iterable<? extends E>)
> > F extends Object declared in method <F,T>transform(Iterable<F>,Function<? super F,? extends T>)
> > T extends Object declared in method <F,T>transform(Iterable<F>,Function<? super F,? extends T>)
> > where CAP#1 is a fresh type-variable:
> > CAP#1 extends Object from capture of ?
> > Note: /home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/main/java/org/apache/aurora/common/testing/easymock/EasyMockTest.java uses or overrides a deprecated API.
> > Note: Recompile with -Xlint:deprecation for details.
> > Note: Some input files use unchecked or unsafe operations.
> > Note: Recompile with -Xlint:unchecked for details.
> > 8 errors
> > FAILED
> >
> > FAILURE: Build failed with an exception.
> >
> > * What went wrong:
> > Execution failed for task ':commons:compileJava'.
> > > Compilation failed; see the compiler error output for details.
> >
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
> >
> > BUILD FAILED
> >
> > Total time: 2 mins 36.803 secs
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
Weird, let's ignore the build result for the purposes of this review - it's clearly false. I'll poke around in jenkins, wonder if the JDK version changed on us.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45076/#review124421
-----------------------------------------------------------
On March 19, 2016, 1 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45076/
> -----------------------------------------------------------
>
> (Updated March 19, 2016, 1 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I have opted for a very simple, incremental improvement here.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979
>
> Diff: https://reviews.apache.org/r/45076/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> aurora-landing-page.png
> https://reviews.apache.org/media/uploaded/files/2016/03/19/9a809739-966a-49e3-bf69-df03754be1c8__aurora-landing-page.png
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 45076: Improve presentation and organization of the
scheduler landing page
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45076/#review124421
-----------------------------------------------------------
Master (b24619b) is red with this patch.
./build-support/jenkins/build.sh
CAP#1 extends Unit<CAP#1> from capture of ?
/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java:44: error: incompatible types: cannot infer type-variable(s) E,F,T
return ImmutableList.copyOf(Iterables.transform(Parsers.MULTI_VALUE_SPLITTER.split(raw),
^
(argument mismatch; Iterable<CAP#1> cannot be converted to Iterable<? extends CAP#1>)
where E,F,T are type-variables:
E extends Object declared in method <E>copyOf(Iterable<? extends E>)
F extends Object declared in method <F,T>transform(Iterable<F>,Function<? super F,? extends T>)
T extends Object declared in method <F,T>transform(Iterable<F>,Function<? super F,? extends T>)
where CAP#1 is a fresh type-variable:
CAP#1 extends Object from capture of ?
/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java:46: error: incompatible types: cannot infer type-variable(s) E,F,T
return ImmutableSet.copyOf(Iterables.transform(Parsers.MULTI_VALUE_SPLITTER.split(raw),
^
(argument mismatch; Iterable<CAP#1> cannot be converted to Iterable<? extends CAP#1>)
where E,F,T are type-variables:
E extends Object declared in method <E>copyOf(Iterable<? extends E>)
F extends Object declared in method <F,T>transform(Iterable<F>,Function<? super F,? extends T>)
T extends Object declared in method <F,T>transform(Iterable<F>,Function<? super F,? extends T>)
where CAP#1 is a fresh type-variable:
CAP#1 extends Object from capture of ?
Note: /home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/main/java/org/apache/aurora/common/testing/easymock/EasyMockTest.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
8 errors
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':commons:compileJava'.
> Compilation failed; see the compiler error output for details.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 2 mins 36.803 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 19, 2016, 8 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45076/
> -----------------------------------------------------------
>
> (Updated March 19, 2016, 8 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I have opted for a very simple, incremental improvement here.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979
>
> Diff: https://reviews.apache.org/r/45076/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> aurora-landing-page.png
> https://reviews.apache.org/media/uploaded/files/2016/03/19/9a809739-966a-49e3-bf69-df03754be1c8__aurora-landing-page.png
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 45076: Improve presentation and organization of the
scheduler landing page
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45076/#review124424
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On March 19, 2016, 1 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45076/
> -----------------------------------------------------------
>
> (Updated March 19, 2016, 1 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> I have opted for a very simple, incremental improvement here.
>
>
> Diffs
> -----
>
> src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979
>
> Diff: https://reviews.apache.org/r/45076/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> aurora-landing-page.png
> https://reviews.apache.org/media/uploaded/files/2016/03/19/9a809739-966a-49e3-bf69-df03754be1c8__aurora-landing-page.png
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 45076: Improve presentation and organization of the
scheduler landing page
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45076/
-----------------------------------------------------------
(Updated March 19, 2016, 9 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Repository: aurora
Description
-------
I have opted for a very simple, incremental improvement here.
Diffs
-----
src/main/resources/scheduler/assets/index.html d0bd897524a4c763d11a601898b663fec672e979
Diff: https://reviews.apache.org/r/45076/diff/
Testing
-------
File Attachments (updated)
----------------
aurora-landing-page.png
https://reviews.apache.org/media/uploaded/files/2016/03/19/9a809739-966a-49e3-bf69-df03754be1c8__aurora-landing-page.png
Thanks,
Stephan Erb