You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/05/01 08:04:37 UTC

[GitHub] [commons-daemon] markt-asf commented on a diff in pull request #39: Fix for https://issues.redhat.com/browse/JBCS-1261

markt-asf commented on code in PR #39:
URL: https://github.com/apache/commons-daemon/pull/39#discussion_r862439030


##########
src/native/windows/src/rprocess.c:
##########
@@ -316,13 +373,16 @@ static BOOL __apxProcessClose(APXHANDLE hProcess)
     lpProc = APXHANDLE_DATA(hProcess);
     CHECK_IF_ACTIVE(lpProc);
 
+    __apxProcessTerminateChild(lpProc->stProcInfo.dwProcessId, TRUE);
     /* Try to close the child's stdin first */

Review Comment:
   Got it. It was `dryrun` being `TRUE` that I missed. This makes sense now. It generates a debug log of the current child processes before a normal shutdown. The forced shutdown only happens if the normal one goes wrong. LGTM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org