You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by gi...@git.apache.org on 2017/08/11 21:21:44 UTC

[GitHub] kaplanmaxe opened a new pull request #239: CB-13175: fixing windows8.1 crash on startup

kaplanmaxe opened a new pull request #239: CB-13175: fixing windows8.1 crash on startup
URL: https://github.com/apache/cordova-windows/pull/239
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   windows
   
   ### What does this PR do?
   
   Ticket: https://issues.apache.org/jira/browse/CB-13175
    
   This issue is a follow-up to [CB-12784](https://github.com/apache/cordova-windows/pull/232)
   
   The user added the fix in `cordova-js-src/splashscreen.js` however it needs to be added to `template/www/cordova.js` as well. This PR takes the already accepted fix and applies it to `cordova.js` as well.
   
   ### What testing has been done on this change?
   
   Ran on Windows 10 Creators Update (build 15063.250), Ran on Windows 8.1, Ran on Windows 10 mobile
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org