You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2014/03/11 23:58:46 UTC
[jclouds-examples] Compile examples with 1.7.1 and repair bit-rot
(#33)
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds-examples compile-examples
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-examples/pull/33
-- Commit Summary --
* Compile examples with 1.7.1 and repair bit-rot
-- File Changes --
M blobstore-basics/pom.xml (2)
M blobstore-largeblob/pom.xml (2)
M chef-basics/pom.xml (4)
M compute-basics/pom.xml (34)
M pom.xml (24)
-- Patch Links --
https://github.com/jclouds/jclouds-examples/pull/33.patch
https://github.com/jclouds/jclouds-examples/pull/33.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33
Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot
(#33)
Posted by Andrew Phillips <no...@github.com>.
Thanks for the cleanup, @andrewgaul!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33#issuecomment-37499796
Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot
(#33)
Posted by Andrew Phillips <no...@github.com>.
> @@ -24,12 +24,12 @@ under the License.
> <modelVersion>4.0.0</modelVersion>
> <groupId>org.apache.jclouds.examples</groupId>
> <artifactId>chef-basics</artifactId>
> - <version>1.7.0</version>
> + <version>1.7.2-SNAPSHOT</version>
Does this need to be a SNAPSHOT version for the examples? This is **the** 1.7.1 example, no?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33/files#r10552566
Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot
(#33)
Posted by Andrew Phillips <no...@github.com>.
> @@ -24,39 +24,39 @@ under the License.
> <modelVersion>4.0.0</modelVersion>
> <groupId>org.jclouds.examples</groupId>
> <artifactId>compute-basics</artifactId>
> - <version>1.0</version>
> + <version>1.7.2-SNAPSHOT</version>
Same comment as for chef-basics above
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33/files#r10552571
Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot
(#33)
Posted by Andrew Gaul <no...@github.com>.
Closed #33.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33
Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot
(#33)
Posted by Zack Shoylev <no...@github.com>.
Is something broken, are you missing #32 or are you missing the revert?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33#issuecomment-37359723
Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot
(#33)
Posted by Zack Shoylev <no...@github.com>.
Are you refering to https://github.com/jclouds/jclouds-examples/pull/32 ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33#issuecomment-37359486
Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot
(#33)
Posted by Andrew Phillips <no...@github.com>.
> @@ -64,6 +64,24 @@
> </repository>
> </repositories>
>
> + <modules>
> + <module>blobstore-basics</module>
> + <module>blobstore-largeblob</module>
> + <module>chef-basics</module>
> + <module>compute-basics</module>
> + <module>rackspace</module>
> +<!--
> + TODO: These modules have bit-rotted:
Does this mean "they don't compile" or something else..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33/files#r10552583
Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot
(#33)
Posted by Andrew Gaul <no...@github.com>.
@etoews @zack-shoylev the rackspace examples do not compile due to a missing ```NovaTemplateOptions.Builder.configDrive```. Can you update this example and add the rackspace module to pom.xml?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33#issuecomment-37357513
Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot
(#33)
Posted by Andrew Phillips <no...@github.com>.
> </parent>
> <groupId>org.apache.jclouds.examples</groupId>
> <artifactId>jclouds-examples</artifactId>
> - <version>1.7.0-SNAPSHOT</version>
> + <version>1.7.2-SNAPSHOT</version>
Same comment as above - use 1.7.1 here too?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33/files#r10552575
Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot
(#33)
Posted by Andrew Gaul <no...@github.com>.
@zack-shoylev sorry I had a stale tree; I will update the pull request.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33#issuecomment-37359857
Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot
(#33)
Posted by Andrew Gaul <no...@github.com>.
Pushed to master.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33#issuecomment-37472657
Re: [jclouds-examples] Compile examples with 1.7.1 and repair bit-rot
(#33)
Posted by Andrew Gaul <no...@github.com>.
@rcoedo this commit should address some of the issues you encountered.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/33#issuecomment-37357228