You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/23 03:22:38 UTC
[GitHub] [incubator-doris] HappenLee opened a new pull request #3928: [Bug Fix]Fix the core in Data_Stream_Recvr
HappenLee opened a new pull request #3928:
URL: https://github.com/apache/incubator-doris/pull/3928
Remove the map in DataStreamRecvr and replace by vector<pair<Closure*, MonotonicStopWatch>>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on pull request #3928: [Bug Fix]Fix the core in Data_Stream_Recvr
Posted by GitBox <gi...@apache.org>.
chaoyli commented on pull request #3928:
URL: https://github.com/apache/incubator-doris/pull/3928#issuecomment-649166021
You can describe some the solution in the commit message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a change in pull request #3928: [Bug Fix]Fix the core in Data_Stream_Recvr
Posted by GitBox <gi...@apache.org>.
HappenLee commented on a change in pull request #3928:
URL: https://github.com/apache/incubator-doris/pull/3928#discussion_r444612282
##########
File path: be/src/runtime/data_stream_recvr.cc
##########
@@ -176,14 +176,12 @@ Status DataStreamRecvr::SenderQueue::get_batch(RowBatch** next_batch) {
*next_batch = _current_batch.get();
if (!_pending_closures.empty()) {
- auto done = _pending_closures.front();
- done->Run();
+ auto closure_pair = _pending_closures.front();
+ closure_pair.first->Run();
Review comment:

@chaoyli Hiļ¼the MonotonicStopWatch start here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3928: [Bug Fix]Fix the core in Data_Stream_Recvr
Posted by GitBox <gi...@apache.org>.
chaoyli commented on a change in pull request #3928:
URL: https://github.com/apache/incubator-doris/pull/3928#discussion_r444601467
##########
File path: be/src/runtime/data_stream_recvr.cc
##########
@@ -176,14 +176,12 @@ Status DataStreamRecvr::SenderQueue::get_batch(RowBatch** next_batch) {
*next_batch = _current_batch.get();
if (!_pending_closures.empty()) {
- auto done = _pending_closures.front();
- done->Run();
+ auto closure_pair = _pending_closures.front();
+ closure_pair.first->Run();
Review comment:
Seems have not call start() of MonotonicStopWatch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #3928: [Bug Fix]Fix the core in Data_Stream_Recvr
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #3928:
URL: https://github.com/apache/incubator-doris/pull/3928
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org