[jira] Commented: (MUSE-236) shutdown a resource does not terminate its child resources

["Dan Jemiolo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MUSE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524354 ] 

Dan Jemiolo commented on MUSE-236:
----------------------------------

This is more complicated than it seems, because the resource may be preparing to shutdown as part of a system-wide shutdown, in which case the subscriptions are already targeted for shutdown. We'd need to add checks to make sure the subscriptions aren't terminated twice (we have sanity checks to catch this, but that will just result in an exception). A more robust solution might be to subclass WSRL's SimpleImmediateTermination and override the destroy( ) implementation so that it kills all the subscription resources before calling super.destroy( );  (you would only use this WSRL class for your notification producing resources).

> shutdown a resource does not terminate its child resources
> ----------------------------------------------------------
>
>                 Key: MUSE-236
>                 URL: https://issues.apache.org/jira/browse/MUSE-236
>             Project: Muse
>          Issue Type: Bug
>          Components: WSN NotificationProducer, WSN SubscriptionManager
>    Affects Versions: 2.2.0
>         Environment: Muse 2.2.0, Eclipse 3.2.1
>            Reporter: Vinh Nguyen
>            Assignee: Dan Jemiolo
>             Fix For: 2.3.0
>
>
> My resource has the NotificationProducer capability to support the Subscribe operation.  This operation creates a new subscription resource.  But, when I terminate the primary resource, the various subscription resources spawned off of it are not terminated.  So if a remote client forgets to terminate the subcription resources, these objects will remain and suck up memory resources.
> Perhaps a new method should be added:
> ResourceManager.addResource(EndpointReference epr, Resource resource, Resource parent)
> This should map any child resources to a parent resource.  Once a parent resource is terminated, it will automatically terminate the child resources.  Muse's SimpleNotificationProducer should also be updated to call this new method.
> So for subscriptions, if the producer resource is terminated, the supscription resources don't need to stay around anymore since notifications are no longer being generated.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: muse-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: muse-dev-help@ws.apache.org