You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2026/09/03 07:56:03 UTC
[PR] build: drop the rust-toolchain.toml pin (datasketches-rust)
tisonkun opened a new pull request, #272:
URL: https://github.com/apache/datasketches-rust/pull/272
## Problem
`cargo x lint` auto-installs taplo-cli via an unpinned `cargo install taplo-cli` when taplo is not on PATH (`xtask/src/main.rs`, `ensure_installed`). Recent taplo-cli releases pull in transitive dependencies (`icu_*`, `time`) that require rustc 1.88, so the install now fails on a clean environment where the pinned 1.86.0 toolchain from `rust-toolchain.toml` is active.
## Change
Drop `rust-toolchain.toml` entirely:
- The workspace already declares its MSRV with `rust-version` in `Cargo.toml`, and CI verifies it through the test matrix, so the pin is redundant for correctness.
- Every CI job already deleted `rust-toolchain.toml` before installing its toolchain, meaning the pin only affected local development — where it broke `cargo install` of lint tools. The now-obsolete deletion steps are removed from CI.
- `CONTRIBUTING.md` setup instructions are updated: any toolchain at or above the MSRV works for build/test, and a nightly toolchain is required for `cargo x lint` / `cargo x check`.
Verified locally with `cargo x lint` and `cargo x check`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] build: drop the rust-toolchain.toml pin (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #272:
URL: https://github.com/apache/datasketches-rust/pull/272#issuecomment-5522560344
@freakyzoidberg This should resolve the issue you pointed out in the release vote thread.
If the experience still has some issue, I'd either try to improve the error message or pin a version for tool. So far, I tend to use latest dev tools to use their nightly features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] build: drop the rust-toolchain.toml pin (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #272:
URL: https://github.com/apache/datasketches-rust/pull/272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org