You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/14 03:40:18 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #10846:
[FLINK-15576] remove isTemporary property from CatalogFunction API
JingsongLi commented on a change in pull request #10846: [FLINK-15576] remove isTemporary property from CatalogFunction API
URL: https://github.com/apache/flink/pull/10846#discussion_r366139545
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/CreateCatalogFunctionOperation.java
##########
@@ -34,14 +34,18 @@
private final ObjectIdentifier functionIdentifier;
private CatalogFunction catalogFunction;
private boolean ignoreIfExists;
+ private boolean isTemporary;
public CreateCatalogFunctionOperation(
ObjectIdentifier functionIdentifier,
CatalogFunction catalogFunction,
- boolean ignoreIfExists) {
+ boolean ignoreIfExists,
+ boolean isTemporary) {
this.functionIdentifier = functionIdentifier;
this.catalogFunction = catalogFunction;
this.ignoreIfExists = ignoreIfExists;
+ this.isTemporary = isTemporary;
+
Review comment:
remove empty line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services