[jira] [Commented] (OAK-3541) VersionableState.copy doesn't respect OPV flag in the subtree

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970632#comment-14970632 ] 

angela commented on OAK-3541:
-----------------------------

committed proposed patch at rev. 1710135 to unblock my work on OAK-1268; however leaving this issue open as further testing especially of the other OPV flags is required. 

> VersionableState.copy doesn't respect OPV flag in the subtree
> -------------------------------------------------------------
>
>                 Key: OAK-3541
>                 URL: https://issues.apache.org/jira/browse/OAK-3541
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, jcr
>            Reporter: angela
>            Priority: Critical
>              Labels: versioning
>         Attachments: OAK-3541.patch, OAK-3541_test.patch
>
>
> while testing my work in OAK-1268 and OAK-2008, i found that items with OPV IGNORE are being copied into the frozen node of a versionable node upon checkin and only the first level child nodes are being tested for the OPV flag.
> IMHO the OPV flag should be respected for all items in the subtree and act accordingly. The current bug might prevent versionable child nodes from being properly versioned and will copy items that are expected to be ignored (e.g. access control content) into the version store.
> if i am not mistaken the properties are actually tested for the their OPV flag... if that is true, we might even have a bigger issue as the content in the version store is no longer complete and valid (e.g. mandatory/protected/autocreated properties being ignored but the node still being copied over and thus being invalid)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)