You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@spamassassin.apache.org by Olivier Coutu <ol...@zerospam.ca> on 2019/06/10 18:43:19 UTC

__YOU_WON_01 FP on *won’t* with right single quotation mark

https://regex101.com/r/SUqMxn/1/

I understand that a single quote should be used when writing /won't/, 
but it's probably not the first time __YOU_WON_01 hits on /won’t/ with a 
right single quotation mark.

Apparently this can happen automatically in certain text editors when 
there are two apostrophes in the same sentence.

I would suggest a second negative lookahead to correct the issue.

-Olivier


Re: __YOU_WON_01 FP on *won’t* with right single quotation mark

Posted by Bill Cole <sa...@billmail.scconsult.com>.
On 10 Jun 2019, at 14:43, Olivier Coutu wrote:

> https://regex101.com/r/SUqMxn/1/
>
> I understand that a single quote should be used when writing /won't/, 
> but it's probably not the first time __YOU_WON_01 hits on /won’t/ 
> with a right single quotation mark.
>
> Apparently this can happen automatically in certain text editors when 
> there are two apostrophes in the same sentence.
>
> I would suggest a second negative lookahead to correct the issue.

Do you have any examples of this causing a rule with an actual score to 
match non-spam?

Re: __YOU_WON_01 FP on *won’t* with right single quotation mark

Posted by "@lbutlr" <kr...@kreme.com>.
On Jun 10, 2019, at 12:43 PM, Olivier Coutu <ol...@zerospam.ca> wrote:
> I would suggest a second negative lookahead to correct the issue.


If the rule doesn’t hit enough spam, the score goes down. It doesn’t matter if it’s esoterically correct or not.

-- 
If it wasn't for the pirates, I bet Star Wars: Ep III would have mad $50
million its first DAY!


Re: __YOU_WON_01 FP on *won’t* with right single quotation mark

Posted by John Hardin <jh...@impsec.org>.
On Tue, 11 Jun 2019, John Hardin wrote:

> On Tue, 11 Jun 2019, RW wrote:
>
>> On Tue, 11 Jun 2019 09:05:55 -0700 (PDT)
>> John Hardin wrote:
>> 
>> 
>>> Think MSFT's annoying "smart quotes" converting a single typed
>>> apostrophe within a word into a Unicode right single quote so that it
>>> Looks Good.
>>> 
>>> I feel it's a valid issue, and the fix is checked in (at least for
>>> one flavor of Unicode right single quote, I didn't review the entire
>>> Unicode code space).
>> 
>> See also __YOU_WON_05
>
> Good point, I will fix that too.

Olivier sent me a spample and some more changes were needed.

Also, __hk_win_6 hits, and might need a similar exclusion. Hege?


-- 
  John Hardin KA7OHZ                    http://www.impsec.org/~jhardin/
  jhardin@impsec.org    FALaholic #11174     pgpk -a jhardin@impsec.org
  key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C  AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
   Are you a mildly tech-literate politico horrified by the level of
   ignorance demonstrated by lawmakers gearing up to regulate online
   technology they don't even begin to grasp? Cool. Now you have a
   tiny glimpse into a day in the life of a gun owner.   -- Sean Davis
-----------------------------------------------------------------------
  804 days since the first commercial re-flight of an orbital booster (SpaceX)

Re: __YOU_WON_01 FP on *won’t* with right single quotation mark

Posted by John Hardin <jh...@impsec.org>.
On Tue, 11 Jun 2019, RW wrote:

> On Tue, 11 Jun 2019 09:05:55 -0700 (PDT)
> John Hardin wrote:
>
>
>> Think MSFT's annoying "smart quotes" converting a single typed
>> apostrophe within a word into a Unicode right single quote so that it
>> Looks Good.
>>
>> I feel it's a valid issue, and the fix is checked in (at least for
>> one flavor of Unicode right single quote, I didn't review the entire
>> Unicode code space).
>
> See also __YOU_WON_05

Good point, I will fix that too.

-- 
  John Hardin KA7OHZ                    http://www.impsec.org/~jhardin/
  jhardin@impsec.org    FALaholic #11174     pgpk -a jhardin@impsec.org
  key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C  AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
  803 days since the first commercial re-flight of an orbital booster (SpaceX)

Re: __YOU_WON_01 FP on *won’t* with right single quotation mark

Posted by RW <rw...@googlemail.com>.
On Tue, 11 Jun 2019 09:05:55 -0700 (PDT)
John Hardin wrote:


> Think MSFT's annoying "smart quotes" converting a single typed
> apostrophe within a word into a Unicode right single quote so that it
> Looks Good.
> 
> I feel it's a valid issue, and the fix is checked in (at least for
> one flavor of Unicode right single quote, I didn't review the entire
> Unicode code space).

See also __YOU_WON_05

Re: __YOU_WON_01 FP on *won’t* with right single quotation mark

Posted by John Hardin <jh...@impsec.org>.
On Tue, 11 Jun 2019, RW wrote:

> On Mon, 10 Jun 2019 16:12:30 -0700 (PDT)
> John Hardin wrote:
>
>> On Mon, 10 Jun 2019, Olivier Coutu wrote:
>>
>>> https://regex101.com/r/SUqMxn/1/
>>>
>>> I understand that a single quote should be used when
>>> writing /won't/, but it's probably not the first time __YOU_WON_01
>>> hits on /won’t/ with a right single quotation mark.
>>>
>>> Apparently this can happen automatically in certain text editors
>>> when there are two apostrophes in the same sentence.
>>>
>>> I would suggest a second negative lookahead to correct the issue.
>>
>> Thanks, I'll try to get that in for tonight's masscheck.
>
> It seems a bit premature. Possibly some editors do try to convert
> text quoted with two apostrophes into a proper quotation. If one tried
> to convert two legitimate apostrophes into a bogus quote, splitting-up
> words in the process, I'd consider that to be a significant bug.

It's not that.

Think MSFT's annoying "smart quotes" converting a single typed apostrophe 
within a word into a Unicode right single quote so that it Looks Good.

I feel it's a valid issue, and the fix is checked in (at least for one 
flavor of Unicode right single quote, I didn't review the entire Unicode 
code space).


-- 
  John Hardin KA7OHZ                    http://www.impsec.org/~jhardin/
  jhardin@impsec.org    FALaholic #11174     pgpk -a jhardin@impsec.org
  key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C  AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
   ...the Constitution and the Bill of Rights exists to protect
   the individual, not the mob.                      -- Matt Pickering
-----------------------------------------------------------------------
  803 days since the first commercial re-flight of an orbital booster (SpaceX)

Re: __YOU_WON_01 FP on *won’t* with right single quotation mark

Posted by RW <rw...@googlemail.com>.
On Mon, 10 Jun 2019 16:12:30 -0700 (PDT)
John Hardin wrote:

> On Mon, 10 Jun 2019, Olivier Coutu wrote:
> 
> > https://regex101.com/r/SUqMxn/1/
> >
> > I understand that a single quote should be used when
> > writing /won't/, but it's probably not the first time __YOU_WON_01
> > hits on /won’t/ with a right single quotation mark.
> >
> > Apparently this can happen automatically in certain text editors
> > when there are two apostrophes in the same sentence.
> >
> > I would suggest a second negative lookahead to correct the issue.  
> 
> Thanks, I'll try to get that in for tonight's masscheck.

It seems a bit premature. Possibly some editors do try to convert
text quoted with two apostrophes into a proper quotation. If one tried
to convert two legitimate apostrophes into a bogus quote, splitting-up
words in the process, I'd consider that to be a significant bug.






Re: __YOU_WON_01 FP on *won’t* with right single quotation mark

Posted by John Hardin <jh...@impsec.org>.
On Mon, 10 Jun 2019, Olivier Coutu wrote:

> https://regex101.com/r/SUqMxn/1/
>
> I understand that a single quote should be used when writing /won't/, but 
> it's probably not the first time __YOU_WON_01 hits on /won’t/ with a right 
> single quotation mark.
>
> Apparently this can happen automatically in certain text editors when there 
> are two apostrophes in the same sentence.
>
> I would suggest a second negative lookahead to correct the issue.

Thanks, I'll try to get that in for tonight's masscheck.

-- 
  John Hardin KA7OHZ                    http://www.impsec.org/~jhardin/
  jhardin@impsec.org    FALaholic #11174     pgpk -a jhardin@impsec.org
  key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C  AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
   I'm seriously considering getting one of those bright-orange prison
   overalls and stencilling PASSENGER on the back. Along with the paper
   slippers, I ought to be able to walk right through security.
                                              -- Brian Kantor in a.s.r
-----------------------------------------------------------------------
  Today: the 52nd anniversary of Israel's victory in the Six-Day War