You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/11/11 16:36:38 UTC

[GitHub] [incubator-dolphinscheduler] hailin0 opened a new pull request #4056: [Fix][API] Condition task NullPointerException

hailin0 opened a new pull request #4056:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4056


   ## *Tips*
   - *Thanks very much for contributing to Apache DolphinScheduler.*
   - *Please review https://dolphinscheduler.apache.org/en-us/community/index.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   Fix NullPointerException when save condition task.
   
   [ProcessDefinitionServiceImpl.java#L242](https://github.com/apache/incubator-dolphinscheduler/blob/dev/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java#L242)
   
   ## Brief change log
   
   changes:
   Return empty List\<ResourceInfo\> at org.apache.dolphinscheduler.common.task.conditions.ConditionsParameters#getResourceFilesList
   
   
   for example:
   [SubProcessParameters.java#L47](https://github.com/apache/incubator-dolphinscheduler/blob/dev/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/task/subprocess/SubProcessParameters.java#L47)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] lgcareer edited a comment on pull request #4056: [Fix][API] Condition task NullPointerException

Posted by GitBox <gi...@apache.org>.
lgcareer edited a comment on pull request #4056:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4056#issuecomment-725804246


   > sonar check to fail.please check.
   
   hi,I saw it's pr only change one line,but the code smell shows it's duplication rate is 50%,
   may be it is a problem of the code smell rule,So I think it can be merged.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #4056: [Fix][API] Condition task NullPointerException

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4056:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4056#issuecomment-725533396


   SonarCloud Quality Gate failed.
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4056&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4056&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4056&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4056&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4056&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4056&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4056&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje
 ct/issues?id=apache-dolphinscheduler&pullRequest=4056&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4056&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/D.png' alt='D' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4056&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=4056&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4056&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4056&metric=new_coverage&view=list)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/20plus.png' alt='50.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4056&metric=new_duplicated_lines_density&view=list) [50.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=4056&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] CalvinKirs edited a comment on pull request #4056: [Fix][API] Condition task NullPointerException

Posted by GitBox <gi...@apache.org>.
CalvinKirs edited a comment on pull request #4056:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4056#issuecomment-725789616


   sonar check to fail.please check.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] lgcareer commented on pull request #4056: [Fix][API] Condition task NullPointerException

Posted by GitBox <gi...@apache.org>.
lgcareer commented on pull request #4056:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4056#issuecomment-725804246


   > sonar check to fail.please check.
   
   hi,I saw it's pr only change one line,but the code smell shows it's duplication rate is 50%,So I think it can be merged.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] CalvinKirs merged pull request #4056: [Fix][API] Condition task NullPointerException

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #4056:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4056


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #4056: [Fix][API] Condition task NullPointerException

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #4056:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4056#issuecomment-725789616


   you have a D-class code smell, which causes the sonar check to fail.please check.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] hailin0 commented on pull request #4056: [Fix][API] Condition task NullPointerException

Posted by GitBox <gi...@apache.org>.
hailin0 commented on pull request #4056:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4056#issuecomment-725778620


   @dailidong 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on pull request #4056: [Fix][API] Condition task NullPointerException

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #4056:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4056#issuecomment-725806822


   > > sonar check to fail.please check.
   > 
   > hi,I saw it's pr only change one line,but the code smell shows it's duplication rate is 50%,
   > may be it is a problem of the code smell rule,So I think it can be merged.
   
   Yes you are right


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #4056: [Fix][API] Condition task NullPointerException

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #4056:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4056#issuecomment-725531550


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4056?src=pr&el=h1) Report
   > Merging [#4056](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4056?src=pr&el=desc) (7adc671) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/4b502e361fa0d41d142b1f2c0845d64d1dcc1abd?el=desc) (4b502e3) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4056/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4056?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #4056      +/-   ##
   ============================================
   - Coverage     39.93%   39.91%   -0.02%     
   + Complexity     2944     2942       -2     
   ============================================
     Files           458      458              
     Lines         21715    21715              
     Branches       2647     2647              
   ============================================
   - Hits           8671     8667       -4     
   - Misses        12240    12242       +2     
   - Partials        804      806       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4056?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...r/common/task/conditions/ConditionsParameters.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4056/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3Rhc2svY29uZGl0aW9ucy9Db25kaXRpb25zUGFyYW1ldGVycy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4056/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `50.00% <0.00%> (-2.78%)` | `9.00% <0.00%> (-2.00%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4056?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4056?src=pr&el=footer). Last update [4b502e3...7adc671](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org