You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "munendrasn (via GitHub)" <gi...@apache.org> on 2024/05/08 14:28:37 UTC
[PR] Add support to use regional endpoints for STS client while using assume role [iceberg]
munendrasn opened a new pull request, #10289:
URL: https://github.com/apache/iceberg/pull/10289
STS by default uses Global endpoint but AWS recommends to use regional [endpoints](https://aws.amazon.com/blogs/security/how-to-use-regional-aws-sts-endpoints/).
The PR introduces new property `client.assume-role.sts-regional-endpoint-enabled`, when set, stsClient is built region specified, else uses the global endpoint - default behaviour
Keeping the current behaviour as the default, because for some regions regional point need to explicitly enabled. Once the user enables the regional endpoint, then the flag can be set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add support to use regional endpoints for STS client while using assume role [iceberg]
Posted by "munendrasn (via GitHub)" <gi...@apache.org>.
munendrasn closed pull request #10289: Add support to use regional endpoints for STS client while using assume role
URL: https://github.com/apache/iceberg/pull/10289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add support to use regional endpoints for STS client while using assume role [iceberg]
Posted by "munendrasn (via GitHub)" <gi...@apache.org>.
munendrasn commented on PR #10289:
URL: https://github.com/apache/iceberg/pull/10289#issuecomment-2308678240
As AWS sdk is [defaulting](https://docs.aws.amazon.com/sdkref/latest/guide/feature-sts-regionalized-endpoints.html) to `regional` endpoint in latest version, which I have validated with latest tests, I'm closing this PR as primary objective of the change was to use regional endpoints for sts calls
We can keep the tests if required to validate the same but not sure if iceberg repo is write place add those tests cc @amogh-jahagirdar @jackye1995 @nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add support to use regional endpoints for STS client while using assume role [iceberg]
Posted by "munendrasn (via GitHub)" <gi...@apache.org>.
munendrasn commented on PR #10289:
URL: https://github.com/apache/iceberg/pull/10289#issuecomment-2100727870
@jackye1995 @amogh-jahagirdar @nastra Please review.
For testing, couldn't find other way to validate, please suggest if the current approach doesn't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org